Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Neptune Analytics default connections #254

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

michaelnchin
Copy link
Member

Issue #, if available: N/A

Description of changes:

  • Fixed generation of default connection profiles via Docker run arguments when using Neptune Analytics..

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.94%. Comparing base (2ba9fa6) to head (30aeeba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   10.94%   10.94%           
=======================================
  Files         409      409           
  Lines       30421    30421           
  Branches      711      711           
=======================================
  Hits         3331     3331           
  Misses      26757    26757           
  Partials      333      333           
Flag Coverage Δ
unittests 10.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vkagamlyk vkagamlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelnchin michaelnchin merged commit caeebd9 into main Mar 6, 2024
3 checks passed
@michaelnchin michaelnchin deleted the analytics-defaults-fix branch March 6, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants