Rust: Aurora Scenario #5476
Merged
Rust: Aurora Scenario #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavidSouther
added
Rust
cpyle0819
reviewed
Oct 6, 2023
cpyle0819
reviewed
Oct 6, 2023
cpyle0819
reviewed
Oct 6, 2023
cpyle0819
reviewed
Oct 6, 2023
cpyle0819
reviewed
Oct 6, 2023
cpyle0819
reviewed
Oct 6, 2023
cpyle0819
reviewed
Oct 6, 2023
cpyle0819
reviewed
Oct 6, 2023
|
Mostly just some general questions, but there are missing copyright headers and tests are needed. |
DavidSouther
force-pushed
the
rust/scenario/aurora
branch
4 times, most recently
from
6445730 to
a7493b4
Compare
|
Tests LGTM. |
DavidSouther
force-pushed
the
rust/scenario/aurora
branch
from
6a6544b to
6e511fb
Compare
DavidSouther
force-pushed
the
rust/scenario/aurora
branch
from
6e511fb to
791d477
Compare
cpyle0819
reviewed
Oct 20, 2023
cpyle0819
reviewed
Oct 20, 2023
cpyle0819
reviewed
Oct 20, 2023
cpyle0819
reviewed
Oct 20, 2023
cpyle0819
approved these changes
Oct 20, 2023
lkdavies
added
Text Review complete
DavidSouther
force-pushed
the
rust/scenario/aurora
branch
2 times, most recently
from
e3e359a to
98f5e8f
Compare
Refactor: extracted rds caller Tests for set_engine Added get_engines test Finished non-waiter tests Added waiting test
DavidSouther
force-pushed
the
rust/scenario/aurora
branch
from
98f5e8f to
faebb77
Compare
scmacdon
approved these changes
Oct 24, 2023
scmacdon
added
On Call Review complete
ford-at-aws
pushed a commit
that referenced
this pull request
Dec 15, 2023
* WIP scenario outline * Finished fleshing out scenario structure. * 80% impl and need to do more research on Aurora DB Engines, Engine Families, etc * Use secrecy for the password and refactor the bin. Types check * Use constant DB_ENGINE * Better handle existing parameter group. Refactor: extracted rds caller Tests for set_engine Added get_engines test Finished non-waiter tests Added waiting test * Split scenario mod and tests. * Add snapshot * Moved Aurora, bump the clap version, and add Aurora metadata. * README update * Fix snippet_files bad file path * Fix metadata * Fix rename * Format * Editorial updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a Rust example for Aurora scenario #3588 (closes #4992)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.