Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++,Bash: Multi-service, update bucket names. #6944

Conversation

meyertst-aws
Copy link
Contributor

This update adds user input to replace "amzn-s3-demo-bucket" for bucket names.

It adds waiters to DynamoDB code to fix some testing issues.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meyertst-aws meyertst-aws added C++ This issue relates to the AWS SDK for C++ Shell Tools written in bash/sh Task A general update to the code base for language clarification, missing actions, tests, etc. labels Sep 30, 2024
@meyertst-aws meyertst-aws requested a review from a team September 30, 2024 18:16
@meyertst-aws meyertst-aws self-assigned this Sep 30, 2024
@meyertst-aws meyertst-aws requested review from scmacdon and removed request for a team September 30, 2024 18:16
@github-actions github-actions bot added the CLI Relates to the AWS CLI label Sep 30, 2024
@meyertst-aws meyertst-aws force-pushed the 6903-update-bucket-names-in-all-c++-examples-to-confirm-with-guidelines branch from 7415f65 to 57c4275 Compare September 30, 2024 19:15
@meyertst-aws meyertst-aws added the On Call Review needed This work needs an on-call review label Sep 30, 2024
@meyertst-aws meyertst-aws changed the title 6903 update bucket names in all c++ examples to confirm with guidelines C++,Bash: Multi-service, update bucket names. Oct 1, 2024
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Oct 1, 2024
@rlhagerm rlhagerm merged commit 4c5489e into awsdocs:main Oct 1, 2024
18 of 20 checks passed
@meyertst-aws meyertst-aws deleted the 6903-update-bucket-names-in-all-c++-examples-to-confirm-with-guidelines branch November 7, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ This issue relates to the AWS SDK for C++ CLI Relates to the AWS CLI On Call Review complete On call review complete Shell Tools written in bash/sh Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants