Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP: S3 Express Basics scenario #6975

Merged
merged 2 commits into from
Oct 24, 2024
Merged

PHP: S3 Express Basics scenario #6975

merged 2 commits into from
Oct 24, 2024

Conversation

beqqrry-aws
Copy link
Contributor

This pull request submits the Scout for S3 Express Basics scenario using AWS SDK for PHP v3.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@beqqrry-aws beqqrry-aws self-assigned this Oct 14, 2024
@github-actions github-actions bot added the PHP This issue relates to the AWS SDK for PHP label Oct 14, 2024
@beqqrry-aws beqqrry-aws force-pushed the php_s3_express_basics branch from 583aef3 to ec27158 Compare October 14, 2024 18:25
@beqqrry-aws beqqrry-aws added the Scout An example which other languages will use for reference later on. label Oct 14, 2024
@beqqrry-aws beqqrry-aws force-pushed the php_s3_express_basics branch 2 times, most recently from 167e547 to e9d24b9 Compare October 14, 2024 18:31
@beqqrry-aws beqqrry-aws requested review from a team, rlhagerm and ford-at-aws and removed request for a team and rlhagerm October 15, 2024 17:01
@beqqrry-aws beqqrry-aws marked this pull request as ready for review October 15, 2024 17:03
@beqqrry-aws beqqrry-aws added the Basics A basic code example showing the core actions for a particular service. label Oct 15, 2024
ford-at-aws
ford-at-aws requested changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions about the EC2 file; the S3 content looks great.

php/example_code/ec2/EC2Service.php Show resolved Hide resolved
php/example_code/ec2/EC2Service.php Outdated Show resolved Hide resolved
php/example_code/ec2/EC2Service.php Outdated Show resolved Hide resolved
php/example_code/ec2/EC2Service.php Outdated Show resolved Hide resolved
php/example_code/ec2/EC2Service.php Outdated Show resolved Hide resolved
php/example_code/ec2/EC2Service.php Show resolved Hide resolved
php/example_code/phpunit.xml Show resolved Hide resolved
@ford-at-aws ford-at-aws force-pushed the php_s3_express_basics branch from 6bda140 to ea35263 Compare October 22, 2024 18:04
@ford-at-aws ford-at-aws added the On Call Review complete On call review complete label Oct 22, 2024
@ford-at-aws ford-at-aws force-pushed the php_s3_express_basics branch from ea35263 to d2a1c71 Compare October 24, 2024 13:35
@ford-at-aws ford-at-aws merged commit c838b2e into awsdocs:main Oct 24, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ford-at-aws ford-at-aws ford-at-aws approved these changes

Assignees

@beqqrry-aws beqqrry-aws

Labels
Basics A basic code example showing the core actions for a particular service. On Call Review complete On call review complete PHP This issue relates to the AWS SDK for PHP Scout An example which other languages will use for reference later on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beqqrry-aws @ford-at-aws