Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java V2 Add the Firehose scenario #7144

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Java V2 Add the Firehose scenario #7144

merged 14 commits into from
Dec 13, 2024

Conversation

scmacdon
Copy link
Contributor

This pull request adds the Java V2 Firehose scenario.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon added Java-v2 This issue relates to the AWS SDK for Java V2 Follow After Scouts, more languages are added to examples as Follows. labels Dec 11, 2024
@scmacdon scmacdon self-assigned this Dec 11, 2024
meyertst-aws
meyertst-aws approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@meyertst-aws meyertst-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there 2 sample_records.json?
These are very big files.

javav2/example_code/firehose/src/main/java/com/example/firehose/scenario/FirehoseScenario.java Outdated Show resolved Hide resolved
javav2/example_code/firehose/src/main/java/com/example/firehose/scenario/FirehoseScenario.java Outdated Show resolved Hide resolved
javav2/example_code/firehose/src/main/java/com/example/firehose/scenario/FirehoseScenario.java Outdated Show resolved Hide resolved
@scmacdon scmacdon added the On Call Review needed This work needs an on-call review label Dec 13, 2024
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Dec 13, 2024
@rlhagerm rlhagerm added the Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. label Dec 13, 2024
@rlhagerm rlhagerm merged commit 8ea9e17 into awsdocs:main Dec 13, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyertst-aws meyertst-aws meyertst-aws approved these changes

Assignees

@scmacdon scmacdon

Labels
Follow After Scouts, more languages are added to examples as Follows. Java-v2 This issue relates to the AWS SDK for Java V2 On Call Review complete On call review complete Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scmacdon @meyertst-aws @rlhagerm