-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.NET v4 preview: adding example folders for Bedrock #7146
Open
rlhagerm
wants to merge
9
commits into
awsdocs:main
Choose a base branch
from
rlhagerm:dotnet-version-updates-pt2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rlhagerm
added
Task
A general update to the code base for language clarification, missing actions, tests, etc.
.NET
Pull requests that update .net code
labels
Dec 11, 2024
rlhagerm
requested review from
a team and
beqqrry-aws
and removed request for
a team
December 11, 2024 17:48
rlhagerm
force-pushed
the
dotnet-version-updates-pt2
branch
from
December 30, 2024 14:59
0b7e57f
to
91dbbb5
Compare
rlhagerm
force-pushed
the
dotnet-version-updates-pt2
branch
from
January 7, 2025 14:49
91dbbb5
to
a4f9c1f
Compare
scmacdon
approved these changes
Jan 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR and its files look good.
rlhagerm
added
On Call Review complete
On call review complete
On Call Review needed
This work needs an on-call review
and removed
On Call Review complete
On call review complete
labels
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
.NET
Pull requests that update .net code
On Call Review needed
This work needs an on-call review
Task
A general update to the code base for language clarification, missing actions, tests, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds example folders for preview version for Bedrock. Metadata is not included, and will be added separately.
The Bedrock examples are updated to .NET 8, with updated null collection handling to match the SDK preview updates, and updated references to all projects.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.