-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update submodules #89
Changes from all commits
b4a6ce6
3dcf78b
ab91d28
565f33c
ad641c6
69d34b7
ecfb490
85e8706
1d72604
6af507a
8b2452f
e5ee196
8b7f5ff
270e7df
7d806d9
46bd983
1a58640
7dfa2d6
c9827ac
fefca3f
ab2493a
6185d44
91a5197
21a0895
f00dfc0
c7040c3
da42027
5dbcc56
1e821f0
02d54b8
bd2022e
41b9b25
759548c
ca78391
d817d11
9d900fb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,7 +68,7 @@ jobs: | |
./linux-container-ci.sh ${{ env.BUILDER_VERSION }} aws-crt-${{ env.LINUX_BASE_IMAGE }} build -p ${{ env.PACKAGE_NAME }} --compiler=${{ matrix.compiler }} --spec downstream | ||
linux_mono: | ||
runs-on: ubuntu-20.04 | ||
runs-on: ubuntu-20.04 | ||
steps: | ||
- name: Build ${{ env.PACKAGE_NAME }} | ||
run: | | ||
|
@@ -94,6 +94,10 @@ jobs: | |
matrix: | ||
arch: [x64] | ||
steps: | ||
- name: Setup dotnet # Use setup dotnet action as Windows-2019 image no longer contains .net5.0 | ||
uses: actions/setup-dotnet@v3 | ||
with: | ||
dotnet-version: '5.0.x' | ||
- uses: ilammy/msvc-dev-cmd@v1 | ||
with: | ||
arch: ${{ matrix.arch }} | ||
|
@@ -104,12 +108,17 @@ jobs: | |
python -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz?run=${{ env.RUN }}', 'builder.pyz')" | ||
python builder.pyz build -p ${{ env.PACKAGE_NAME }} --spec=downstream | ||
# TODO: Fix this to run on 14.0 toolset. Currently, it doesn't respect the toolset parameter. | ||
windows-vc14: | ||
runs-on: windows-2019 | ||
strategy: | ||
matrix: | ||
arch: [x86, x64] | ||
steps: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not your fault, but this "windows-vc14" run isn't doing what it claims. vc14 means version 14.0 of the compiler, aka toolset 140, which came with Visual Studio 2015, but you can still use those older toolset versions with later versions of Visual Studio but it's actually just using the default compiler on this machine, which is Visual Studio 2019's version 14.29 Here's the line in the logs where you see what it's actually using.
and then you cross-reference that against the Wikipedia page that details what the hell those version numbers mean. And you see that 14.29 means it's the latest build Visual Studio 2019 compiler There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added a TODO for now. |
||
- name: Setup dotnet | ||
uses: actions/setup-dotnet@v3 | ||
with: | ||
dotnet-version: '5.0.x' #TODO: Specify architecture to install 32 bit .net when that is supported (https://github.com/actions/setup-dotnet/issues/72) | ||
- uses: ilammy/msvc-dev-cmd@v1 | ||
with: | ||
toolset: 14.0 | ||
|
+11 −0 | .github/workflows/ci.yml | |
+5 −5 | builder.json | |
+15 −2 | cmake/aws-c-cal-config.cmake | |
+11 −3 | cmake/modules/Findcrypto.cmake | |
+6 −2 | source/unix/openssl_platform_init.c |
+53 −74 | .github/workflows/ci.yml | |
+2 −2 | .github/workflows/clang-format.yml | |
+15 −3 | cmake/aws-c-compression-config.cmake | |
+3 −3 | source/huffman.c |
+43 −21 | .github/workflows/ci.yml | |
+2 −2 | .github/workflows/clang-format.yml | |
+2 −1 | builder.json | |
+15 −3 | cmake/aws-checksums-config.cmake | |
+12 −26 | source/intel/asm/crc32c_sse42_asm.c |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not your fault, but
ilammy/msvc-dev-cmd
<-- in my experience, this github action has no effectit ended up in all our ci.yml files when we were first setting up our repos and copy/pasting everything
later we discovered it had no effect, but we've never made a concerted effort to fix this across our 20+ repos :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://tenor.com/en-GB/view/coding-programming-pink-panther-when-you-delete-a-block-of-code-that-you-though-was-useless-gif-17338075