RIB fragment #237
Merged
RIB fragment #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # libraries/rib-base/src/main/java/com/badoo/ribs/android/RibActivity.kt
CherryPerry
commented
Jan 26, 2021
libraries/rib-base/src/main/java/com/badoo/ribs/android/activitystarter/ActivityStarterHost.kt
Outdated
Show resolved
Hide resolved
|
Some tests? |
|
@zsoltk ready to review and merge. |
zsoltk
reviewed
Jan 27, 2021
libraries/rib-base/src/main/java/com/badoo/ribs/android/integrationpoint/IntegrationPoint.kt
Outdated
Show resolved
Hide resolved
zsoltk
reviewed
Jan 27, 2021
zsoltk
reviewed
Jan 27, 2021
libraries/rib-base/src/main/java/com/badoo/ribs/android/integrationpoint/IntegrationPoint.kt
Outdated
Show resolved
Hide resolved
zsoltk
reviewed
Jan 27, 2021
SavinMike
reviewed
Jan 27, 2021
libraries/rib-base/src/main/java/com/badoo/ribs/android/dialog/DefaultDialogLauncher.kt
Outdated
Show resolved
Hide resolved
|
|
||
| class ActivityIntegrationPoint( | ||
| open class ActivityIntegrationPoint( |
There was a problem hiding this comment.
From my point of view create own class of ActivityIntegreationPoint only for overriding DialogLauncher sounds strange, can we add DialogLauncher as constructor field?
There was a problem hiding this comment.
There is no meaning in exposing only DialogLauncher via contractor parameter. But at same time we can't expose ActivityStarter and PermissionRequester as default parameters because they depends on internal RequestCodeRegistry.
Please extend ActivityIntegrationPoint and override the field, use createIntegrationPoint to replace default one in activity or fragment.
libraries/rib-base/src/main/java/com/badoo/ribs/android/RibFragment.kt
Outdated
Show resolved
Hide resolved
...s/rib-base/src/main/java/com/badoo/ribs/android/integrationpoint/FragmentIntegrationPoint.kt
Show resolved
Hide resolved
libraries/rib-base/src/main/java/com/badoo/ribs/android/integrationpoint/IntegrationPoint.kt
Show resolved
Hide resolved
libraries/rib-base/src/main/java/com/badoo/ribs/android/store/RetainedInstanceStoreViewModel.kt
Show resolved
Hide resolved
sandbox/src/main/java/com/badoo/ribs/sandbox/app/RecyclerViewTestActivity.kt
Show resolved
Hide resolved
zsoltk
approved these changes
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After some additional investigations, I discovered, that using
isFinishingflag combinations for fragment still has issues.ViewModel is only option for fragments. I decided to use ViewModel in activities too to have consistent behaviour.
Depends on #235