Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the unused argument df #137

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

remove the unused argument df #137

wants to merge 2 commits into from

Conversation

baggepinnen
Copy link
Owner

@baggepinnen baggepinnen commented Jun 3, 2024

df for APF is only used in smoothing, where it is used in the call

 logpdf(df, xb[m,t+1], f(xf[n,t],u[t],p,t), t)

to the custom method

@inline Distributions.logpdf(d::Distribution,x,xp,t) = logpdf(d,x-xp)

This PR thus has to

  1. Not remove the argument from the docs completely
  2. Require that a custom distribution or a custom logpdf function is supplied instead
  3. Update the beetle tutorial to show how this is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant