fix/44 check amount is larger than zero in cross transfer

balancednetwork · Nov 6, 2023 · 6786149 · 6786149
1 parent bca10dd
commit 6786149
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/contracts/token-contracts/cw-hub-bnusd/src/contract.rs b/contracts/token-contracts/cw-hub-bnusd/src/contract.rs
@@ -175,7 +175,7 @@ mod execute {
     use std::str::from_utf8;
 
     use bytes::BytesMut;
-    use cosmwasm_std::{to_binary, Addr, CosmosMsg, SubMsg};
+    use cosmwasm_std::{to_binary, Addr, CosmosMsg, SubMsg, ensure};
     use cw_common::network_address::NetId;
     use cw_ibc_rlp_lib::rlp::{decode, encode};
     use debug_print::debug_println;
@@ -257,6 +257,8 @@ mod execute {
         if !to.validate_foreign_addresses() {
             return Err(ContractError::InvalidNetworkAddress);
         }
+        ensure!(amount > 0, ContractError::InvalidAmount);
+
         let funds = info.funds.clone();
         let nid = NID.load(deps.storage)?;
         let hub_net: NetId = DESTINATION_TOKEN_NET.load(deps.storage)?;

diff --git a/contracts/token-contracts/cw-hub-bnusd/src/error.rs b/contracts/token-contracts/cw-hub-bnusd/src/error.rs
@@ -16,6 +16,8 @@ pub enum ContractError {
     WrongNetwork,
     #[error("Invalid to Address")]
     InvalidToAddress,
+    #[error("Token amount can't be zero")]
+    InvalidAmount,
     #[error("OnlyCallService")]
     OnlyCallService,
     #[error("OnlyHub")]