Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: xcall_network_address removed from config #16

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

TRSSMG
Copy link

@TRSSMG TRSSMG commented Nov 1, 2024

Description

Commit Message

type: commit message

see the guidelines for commit messages.

Changelog Entry

version: <log entry>

Checklist

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines
  • I have added version bump label on PR.

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.43%. Comparing base (72f8619) to head (42d246d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
+ Coverage   82.41%   82.43%   +0.02%     
==========================================
  Files          32       32              
  Lines        1558     1560       +2     
==========================================
+ Hits         1284     1286       +2     
  Misses        274      274              
Flag Coverage Δ
rust 82.43% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
contracts/asset_manager/src/config.rs 100.00% <ø> (ø)
contracts/asset_manager/src/contract.rs 90.49% <100.00%> (+0.03%) ⬆️
contracts/balanced_doller/src/balanced_dollar.rs 96.32% <100.00%> (+0.02%) ⬆️
contracts/balanced_doller/src/config.rs 100.00% <ø> (ø)

@TRSSMG TRSSMG requested a review from AntonAndell November 1, 2024 07:12
Copy link

@AntonAndell AntonAndell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TRSSMG TRSSMG changed the title improvement: xcall_network_address removed from config enhancement: xcall_network_address removed from config Nov 1, 2024
@TRSSMG TRSSMG changed the title enhancement: xcall_network_address removed from config refactor: xcall_network_address removed from config Nov 1, 2024
@TRSSMG TRSSMG added the enhancement New feature or request label Nov 1, 2024
@bishalbikram bishalbikram force-pushed the hotfix/xcall_network_address branch from 44b60fa to 42d246d Compare November 1, 2024 08:34
@bishalbikram bishalbikram merged commit f81ebcf into main Nov 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants