Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is sails-mongodb plugin still maintained? #6899

Closed
jannomeister opened this issue Nov 26, 2019 · 16 comments
Closed

is sails-mongodb plugin still maintained? #6899

jannomeister opened this issue Nov 26, 2019 · 16 comments
Labels
has pr There is an open pull request (in this repo or elsewhere) related to this issue. mongo Issue only occurs when using MongoDB orm Related to models, datastores, orm config, Waterline, sails-hook-orm, etc. question

Comments

@jannomeister
Copy link

No description provided.

@sailsbot
Copy link

@jannomeister Thanks for posting! We'll take a look as soon as possible.

In the mean time, there are a few ways you can help speed things along:

  • look for a workaround. (Even if it's just temporary, sharing your solution can save someone else a lot of time and effort.)
  • tell us why this issue is important to you and your team. What are you trying to accomplish? (Submissions with a little bit of human context tend to be easier to understand and faster to resolve.)
  • make sure you've provided clear instructions on how to reproduce the bug from a clean install.
  • double-check that you've provided all of the requested version and dependency information. (Some of this info might seem irrelevant at first, like which database adapter you're using, but we ask that you include it anyway. Oftentimes an issue is caused by a confluence of unexpected factors, and it can save everybody a ton of time to know all the details up front.)
  • read the code of conduct.
  • if appropriate, ask your business to sponsor your issue. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
  • let us know if you are using a 3rd party plugin; whether that's a database adapter, a non-standard view engine, or any other dependency maintained by someone other than our core team. (Besides the name of the 3rd party package, it helps to include the exact version you're using. If you're unsure, check out this list of all the core packages we maintain.)

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

@johnabrams7 johnabrams7 added mongo Issue only occurs when using MongoDB orm Related to models, datastores, orm config, Waterline, sails-hook-orm, etc. question labels Nov 28, 2019
@johnabrams7
Copy link
Contributor

@jannomeister Hi, yes it's currently being worked on by several developers and PRs including a significant one to upgrade the MongoDB drivers. It should be updated on npm soon enough once things have been tested thoroughly.

@jannomeister
Copy link
Author

@johnabrams7 thanks! because I really love this framework. And I thought its not properly because can't find a good readme for roadmap or milestone.

@WeaponizedLego
Copy link

@johnabrams7 does the current version have support for remote mongo servers like the one hosted at mongoDB atlas, or is that something that won't be added until the new update is done?

the current version of connection string provided by mongoDB atlas is much different from the one example provided on the adapters page, and also doesn't provide a port nr.
atlas version:
mongodb+srv://:@/test?retryWrites=true&w=majority

@johnabrams7
Copy link
Contributor

johnabrams7 commented Dec 24, 2019

@WeaponizedLego Not officially but support is being implemented. In the meantime, you can try a workaround for using mongoDB atlas with sails by manually updating the mongodb dependency (editing the package.json version) and the mongodb-core version, then using the mongodb atlas url in the db config.

@Josebaseba
Copy link
Contributor

hey @johnabrams7 the official support for mongo 3.4 is ending up this month and DB services as mlab are forcing the update to 3.6, the npm package still in the 1.0.1 which means that .avg && .sum are going to start failing in production. The 1.0.2 sails-mongo version with mongo 3.6 support is required ASAP.

Plus, we need to have @luislobo 's PR merged and in npm too, to keep sails-mongo up to date for the next years.

This is a really important issue right now.

Thanks.

@rachaelshaw
Copy link
Member

@Josebaseba thanks for pointing out how time-sensitive this is. Any chance you're available to help? Our team isn't actively using Mongo on a project right now, so we don't have a whole lot of context for what needs to change, but we're available to make it happen before support for 3.4 ends.

Last I checked in with @luislobo, balderdashy/sails-mongo#480 wasn't quite ready for merging. It has some more overarching changes, so if there's a way to work in a quick fix before merging in that PR, that would be ideal.

@luislobo
Copy link
Contributor

luislobo commented Jan 14, 2020 via email

@Josebaseba
Copy link
Contributor

Josebaseba commented Jan 14, 2020

@rachaelshaw if you publish the current master branch as the 1.0.2 version then we'll have full support for the 3.6 mongo version which hasn't an end of life date set yet, so we'll have more time to work on the PR.

The master brach is passing all the tests and it works fine in prod, I tested myself. It doesn't break anything or requires any code change, we just needed an internal little change in to the .sum && .avg methods, so a x.x.2 minor release should be fine.

Probably it'll work against mongo 4 too, but I didn't test it.

After that we can work updating the drivers, adding atlas support and all the long term stuff that the repo needs.

@rachaelshaw
Copy link
Member

Thanks for the update @Josebaseba & @luislobo; I also tried out the latest from master yesterday and it's looking good. The team and I have a couple more things we want to test out manually tomorrow before publishing, but should be able to release a new version after that. Thanks for your patience!

@hengsok
Copy link

hengsok commented Jan 25, 2020

I have made an independent quick fix with minimal changes for sails-mongo to work with the latest nodejs module mongodb-3.5.2 which will support MongoDB 4.

https://github.com/hengsok/sails-mongo

@johnabrams7
Copy link
Contributor

johnabrams7 commented Jan 31, 2020

@hengsok @Josebaseba @WeaponizedLego @jannomeister
Wanted to let everyone know sails-mongo 1.1.0 has been released 👍

Updated drivers (official support for Mongo 3.6), compatibility, functionality, and other various tweaks - see changelog.

@Josebaseba
Copy link
Contributor

Using some of the work of @hengsok I've made a PR balderdashy/sails-mongo#483 that upgrades the drivers, allowing us to use 3.6, 4.0 and 4.2 and the 'new' mongodb+srv:// option that Atlas requires.

@WeaponizedLego @jannomeister @johnabrams7

@johnabrams7 johnabrams7 added the has pr There is an open pull request (in this repo or elsewhere) related to this issue. label Apr 3, 2020
@johnabrams7
Copy link
Contributor

Thanks for the sails-mongo PR @Josebaseba ! Added this to our plans to have the team check it out for further analysis/decision. Appreciate all the updates thus far!

@johnabrams7
Copy link
Contributor

@jannomeister @Josebaseba @hengsok @WeaponizedLego We merged balderdashy/sails-mongo#485 and @luislobo is working on merging together different driver-related PRs onto one branch.

@DominusKelvin
Copy link
Contributor

Hey @jannomeister, @johnabrams7, @Josebaseba @hengsok, and, @WeaponizedLego , I'll be closing this issue as this PR has implemented the upgrade and it has been merged. Thank you for waiting on this 💙

Also you can check here for the upgrade information. 👇🏾

https://blog.sailscasts.com/sails-mongo-v2-1-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has pr There is an open pull request (in this repo or elsewhere) related to this issue. mongo Issue only occurs when using MongoDB orm Related to models, datastores, orm config, Waterline, sails-hook-orm, etc. question
Development

No branches or pull requests

10 participants