-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
is sails-mongodb plugin still maintained? #6899
Comments
@jannomeister Thanks for posting! We'll take a look as soon as possible. In the mean time, there are a few ways you can help speed things along:
Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly. For help with questions about Sails, click here. |
@jannomeister Hi, yes it's currently being worked on by several developers and PRs including a significant one to upgrade the MongoDB drivers. It should be updated on npm soon enough once things have been tested thoroughly. |
@johnabrams7 thanks! because I really love this framework. And I thought its not properly because can't find a good readme for roadmap or milestone. |
@johnabrams7 does the current version have support for remote mongo servers like the one hosted at mongoDB atlas, or is that something that won't be added until the new update is done? the current version of connection string provided by mongoDB atlas is much different from the one example provided on the adapters page, and also doesn't provide a port nr. |
@WeaponizedLego Not officially but support is being implemented. In the meantime, you can try a workaround for using mongoDB atlas with sails by manually updating the mongodb dependency (editing the package.json version) and the mongodb-core version, then using the mongodb atlas url in the db config. |
hey @johnabrams7 the official support for mongo 3.4 is ending up this month and DB services as mlab are forcing the update to 3.6, the npm package still in the 1.0.1 which means that Plus, we need to have @luislobo 's PR merged and in npm too, to keep sails-mongo up to date for the next years. This is a really important issue right now. Thanks. |
@Josebaseba thanks for pointing out how time-sensitive this is. Any chance you're available to help? Our team isn't actively using Mongo on a project right now, so we don't have a whole lot of context for what needs to change, but we're available to make it happen before support for 3.4 ends. Last I checked in with @luislobo, balderdashy/sails-mongo#480 wasn't quite ready for merging. It has some more overarching changes, so if there's a way to work in a quick fix before merging in that PR, that would be ideal. |
I have a PR that updates the drivers. This week is impossible for me to
work on it, I can work with you Joseba if you want to review it next week.
|
@rachaelshaw if you publish the current master branch as the 1.0.2 version then we'll have full support for the 3.6 mongo version which hasn't an end of life date set yet, so we'll have more time to work on the PR. The master brach is passing all the tests and it works fine in prod, I tested myself. It doesn't break anything or requires any code change, we just needed an internal little change in to the Probably it'll work against mongo 4 too, but I didn't test it. After that we can work updating the drivers, adding atlas support and all the long term stuff that the repo needs. |
Thanks for the update @Josebaseba & @luislobo; I also tried out the latest from master yesterday and it's looking good. The team and I have a couple more things we want to test out manually tomorrow before publishing, but should be able to release a new version after that. Thanks for your patience! |
I have made an independent quick fix with minimal changes for sails-mongo to work with the latest nodejs module mongodb-3.5.2 which will support MongoDB 4. |
@hengsok @Josebaseba @WeaponizedLego @jannomeister Updated drivers (official support for Mongo 3.6), compatibility, functionality, and other various tweaks - see changelog. |
Using some of the work of @hengsok I've made a PR balderdashy/sails-mongo#483 that upgrades the drivers, allowing us to use 3.6, 4.0 and 4.2 and the 'new' |
Thanks for the sails-mongo PR @Josebaseba ! Added this to our plans to have the team check it out for further analysis/decision. Appreciate all the updates thus far! |
@jannomeister @Josebaseba @hengsok @WeaponizedLego We merged balderdashy/sails-mongo#485 and @luislobo is working on merging together different driver-related PRs onto one branch. |
Hey @jannomeister, @johnabrams7, @Josebaseba @hengsok, and, @WeaponizedLego , I'll be closing this issue as this PR has implemented the upgrade and it has been merged. Thank you for waiting on this 💙 Also you can check here for the upgrade information. 👇🏾 |
No description provided.
The text was updated successfully, but these errors were encountered: