[implements #6899] Update mongo drivers to latest version 3.5.5

[Josebaseba]

Tested with mongo 3.6, 4.0 and 4.2 and with no breaking changes for the current adapter.

Related with balderdashy/sails#6899

EDIT: All the tests are passing on my machine with remote atlas dbs, the timeout error that appveyor returns it's related with the WATERLINE_ADAPTER_TESTS_URL that you've set internally.

[sailsbot]

Hi @Josebaseba! It looks like the title of your pull request doesn’t quite match our guidelines yet. Would you please edit your pull request's title so that it begins with [proposal], [patch], [fixes #<issue number>], [implements #<other PR number>], or [misc]? Once you've edited it, I'll take another look!

[sailsbot]

Thanks for submitting this pull request, @Josebaseba! We'll look at it ASAP.

In the mean time, here are some ways you can help speed things along:

• discuss this pull request with other contributors and get their feedback. (Reactions and comments can help us make better decisions, anticipate compatibility problems, and prevent bugs.)
• ask another JavaScript developer to review the files changed in this pull request. (Peer reviews definitely don't guarantee perfection, but they help catch mistakes and enourage collaborative thinking. Code reviews are so useful that some open source projects require a minimum number of reviews before even considering a merge!)
• if appropriate, ask your business to sponsor your pull request. (Open source is our passion, and our core maintainers volunteer many of their nights and weekends working on Sails. But you only get so many nights and weekends in life, and stuff gets done a lot faster when you can work on it during normal daylight hours.)
• make sure you've answered the "why?" (Before we can review and merge a pull request, we feel it is important to fully understand the use case: the human reason these changes are important for you, your team, or your organization.)

---

Please remember: never post in a public forum if you believe you've found a genuine security vulnerability. Instead, disclose it responsibly.

For help with questions about Sails, click here.

[Josebaseba]

@johnabrams7 I found out a perfomance issue on production, under a big load of usage. It might be a memory leak, I'll work on it and I'll keep you updated.

[MikeLindenau]

Any updates on this? Thanks for the work on this btw!!

[Josebaseba]

Hey, I couldn't find the reason why it happened, I'm not sure whether it was something related with Atlas and their I/O limit or if the problem was in the code. In the graphs it seemed like if I had way more reads/writes than I should (looking to the online users ratio).

My original thought was that the connection was opening too many times or maybe that it wasn't closing, making more requests at the same time, but I couldn't prove it.

I need to test it more deeply. If you could test it locally or against any mongo service maybe we can find what it fails.

[johnabrams7]

@Josebaseba We recently discussed this PR and are giving it a further examination.

[luislobo]

@Josebaseba I'll contact you in private: we should join forces, merge our two PRs. I want to move yours or mine forward. Already talked to people in the Sails team about this. Sending you an email

[luislobo]

@Josebaseba Were you able to test this PR in your environment? I think you mentioned that you found issues back then (performance?)

[rachaelshaw]

@luislobo @Josebaseba would you say this is ready to merge? I'll be testing it out today, but let me know if there's anything else you were planning to change

[luislobo]

@rachaelshaw Thanks, I've been taking to Mike and we agreed to make it version 2.0.0-0, as there are breaking changes. I'll make these changes today and we can go from there

[Josebaseba]

@luislobo @rachaelshaw everything seems good 👍 I couldn't find any performance issue on my latest tests

[luislobo]

One thing we could do is update it to the latest mongodb 3.5.x node module: 3.5.10

There is already a 3.6.x but we should handle that upgrade later in a separate PR, as it adds more options.

[rachaelshaw]

@luislobo @Josebaseba just published these changes as a prerelease, you can install with npm install sails-mongo@edge