Fix check for errors

ballerina-platform · Nov 21, 2023 · 781e3ee · 781e3ee
1 parent 9041b64
commit 781e3ee
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java b/...ng/src/main/java/org/wso2/ballerinalang/compiler/semantics/analyzer/SemanticAnalyzer.java
@@ -3982,7 +3982,10 @@ public void visit(BLangFail failNode, AnalyzerData data) {
         if (!data.commonAnalyzerData.errorTypes.empty()) {
             BType failExprType = failNode.expr.getBType();
             if (failExprType != symTable.semanticError) {
-                data.commonAnalyzerData.errorTypes.peek().add(types.getErrorTypes(failExprType));
+                BType errorTypes = types.getErrorTypes(failExprType);
+                if (errorTypes != symTable.semanticError) {
+                    data.commonAnalyzerData.errorTypes.peek().add(errorTypes);
+                }
             }
         }
         if (errorExpressionType != symTable.semanticError &&

diff --git a/...na-unit-test/src/test/java/org/ballerinalang/test/statements/dostatement/DoStmtsTest.java b/...na-unit-test/src/test/java/org/ballerinalang/test/statements/dostatement/DoStmtsTest.java
@@ -76,8 +76,6 @@ public void testNegative2() {
         int index = 0;
         BAssertUtil.validateError(negativeFile2, index++, "type 'string' not allowed here; " +
                 "expected an 'error' or a subtype of 'error'", 6, 11);
-        BAssertUtil.validateError(negativeFile2, index++, "incompatible types: expected " +
-                "'other', found 'string'", 8, 12);
         BAssertUtil.validateError(negativeFile2, index++, "invalid error variable; expecting " +
                 "an error type but found 'string' in type definition", 8, 12);
         BAssertUtil.validateError(negativeFile2, index++, "undefined symbol 'd'", 26, 12);