-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce memory taken during compilation #41510
Reduce memory taken during compilation #41510
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #41510 +/- ##
=========================================
Coverage 76.71% 76.72%
+ Complexity 52667 52662 -5
=========================================
Files 2880 2879 -1
Lines 198580 198566 -14
Branches 25801 25797 -4
=========================================
+ Hits 152334 152342 +8
+ Misses 37812 37789 -23
- Partials 8434 8435 +1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
compiler/ballerina-lang/src/main/java/io/ballerina/projects/JBallerinaBackend.java
Show resolved
Hide resolved
.../ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmPackageGen.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
This PR reduces the memory taken during compilation by means of the following.
Fixes #41384
Fixes #41407
Approach
Samples
Remarks
With Ballerina 2201.7.3 version without these changes the following code took about 900 MB memory for the heap at average when compiling the code for the first time.
With these changes introduced on top of that it takes about 700 MB memory for the heap at average when compiling the code for the first time.
Check List