Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the help text of bal format command #41537

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Correct the help text of bal format command #41537

merged 1 commit into from
Nov 2, 2023

Conversation

Ishad-M-I-M
Copy link
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #38681

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Ishad-M-I-M Ishad-M-I-M requested a review from hevayo as a code owner October 18, 2023 09:46
@Ishad-M-I-M Ishad-M-I-M changed the title Correct the help text of bal format command Correct the help text of bal format command Oct 18, 2023
Copy link
Contributor

@poorna2152 poorna2152 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (9f14215) 76.68% compared to head (916ba70) 76.68%.
Report is 32 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41537      +/-   ##
============================================
- Coverage     76.68%   76.68%   -0.01%     
- Complexity    52640    52642       +2     
============================================
  Files          2881     2881              
  Lines        198492   198501       +9     
  Branches      25806    25806              
============================================
+ Hits         152209   152211       +2     
- Misses        37844    37851       +7     
  Partials       8439     8439              
Files Coverage Δ
...in/java/io/ballerina/projects/DocumentContext.java 98.55% <100.00%> (+0.08%) ⬆️
...main/java/io/ballerina/projects/ModuleContext.java 88.17% <100.00%> (+0.08%) ⬆️
...lerinalang/compiler/bir/codegen/CodeGenerator.java 65.11% <100.00%> (ø)
...lerinalang/compiler/desugar/AnnotationDesugar.java 95.62% <100.00%> (ø)
...ballerinalang/compiler/desugar/ClosureDesugar.java 76.85% <100.00%> (+0.02%) ⬆️
...llerinalang/compiler/desugar/ClosureGenerator.java 79.19% <100.00%> (ø)
...g/wso2/ballerinalang/compiler/desugar/Desugar.java 89.38% <100.00%> (+<0.01%) ⬆️
...mpiler/semantics/model/symbols/BPackageSymbol.java 80.00% <ø> (ø)
...java/org/ballerinalang/formatter/cli/Messages.java 70.83% <100.00%> (ø)
.../io/ballerina/cli/task/RunNativeImageTestTask.java 33.75% <0.00%> (ø)
... and 1 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keizer619 keizer619 merged commit 39298db into ballerina-platform:master Nov 2, 2023
15 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Outdated Ballerina Formatter error message
4 participants