-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix xml toString()
error for modified name space attributes
#41541
Fix xml toString()
error for modified name space attributes
#41541
Conversation
.../jballerina-unit-test/src/test/resources/test-src/types/xml/xml-literals-with-namespaces.bal
Outdated
Show resolved
Hide resolved
.../jballerina-unit-test/src/test/resources/test-src/types/xml/xml-literals-with-namespaces.bal
Outdated
Show resolved
Hide resolved
Needs to enable |
.../jballerina-unit-test/src/test/resources/test-src/types/xml/xml-literals-with-namespaces.bal
Outdated
Show resolved
Hide resolved
.../jballerina-unit-test/src/test/resources/test-src/types/xml/xml-literals-with-namespaces.bal
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #41541 +/- ##
=========================================
Coverage 76.69% 76.70%
Complexity 52669 52669
=========================================
Files 2881 2881
Lines 198537 198537
Branches 25812 25812
=========================================
+ Hits 152273 152279 +6
+ Misses 37832 37825 -7
- Partials 8432 8433 +1
☔ View full report in Codecov by Sentry. |
… into fix-xml-toString'
… into fix-xml-toString'
… into fix-xml-toString'
… into fix-xml-toString'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Let's send this to 8.x as well |
Purpose
$subject
Fixes #40373
Fixes #41521
Approach
disableOnOldParser
test group as it is no-longer usedSamples
Check List