-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2201.8.x] Fix performance drop drastically while profiling a Ballerina program #41554
[2201.8.x] Fix performance drop drastically while profiling a Ballerina program #41554
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2201.8.x #41554 +/- ##
==============================================
+ Coverage 76.34% 76.36% +0.01%
- Complexity 52521 52541 +20
==============================================
Files 2881 2880 -1
Lines 198605 198680 +75
Branches 25805 25812 +7
==============================================
+ Hits 151629 151714 +85
+ Misses 38620 38615 -5
+ Partials 8356 8351 -5
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bvm/ballerina-profiler/src/main/java/io/ballerina/runtime/profiler/runtime/Data.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-profiler/src/main/java/io/ballerina/runtime/profiler/runtime/StackTraceMap.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-profiler/src/main/java/io/ballerina/runtime/profiler/ui/FileUtils.java
Outdated
Show resolved
Hide resolved
bvm/ballerina-profiler/src/main/java/io/ballerina/runtime/profiler/ui/FileUtils.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If possible shall we also add a test to check the performance of bal profile
(maybe in another PR). We can use this same snippet #41300 (comment) (1st snippet here) and profile it and check whether it runs under 3 seconds or something like that. We can examine the output and check whether it contains all the user defined functions and reasonable times in the output.
When I tested the output I saw it does not contain isSortedArray
function in the flame graph. How did that get omitted?
Will add a test in master PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cd86be5
into
ballerina-platform:2201.8.x
Purpose
Fixes #41300
Fixes #41547
Check List