Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tool build integration #41710

Merged
merged 34 commits into from
Jan 2, 2024
Merged

New tool build integration #41710

merged 34 commits into from
Jan 2, 2024

Conversation

ShammiL
Copy link
Contributor

@ShammiL ShammiL commented Nov 16, 2023

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

Fixes #41415

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (612e44f) 76.69% compared to head (86947a5) 76.70%.
Report is 84 commits behind head on master.

Files Patch % Lines
...ballerinalang/central/client/CentralAPIClient.java 25.53% 29 Missing and 6 partials ⚠️
...o/ballerina/projects/internal/ManifestBuilder.java 76.92% 16 Missing and 8 partials ⚠️
...lerina/cli/task/RunBallerinaPreBuildToolsTask.java 65.95% 10 Missing and 6 partials ⚠️
...n/java/org/ballerinalang/central/client/Utils.java 60.00% 13 Missing and 1 partial ⚠️
...c/main/java/io/ballerina/projects/ToolContext.java 78.57% 5 Missing and 1 partial ⚠️
...in/java/io/ballerina/cli/task/RunProfilerTask.java 64.28% 4 Missing and 1 partial ⚠️
.../compiler/bir/codegen/interop/JMethodResolver.java 91.17% 1 Missing and 2 partials ⚠️
...c/main/java/io/ballerina/cli/cmd/CleanCommand.java 84.61% 2 Missing ⚠️
...rc/main/java/io/ballerina/cli/utils/FileUtils.java 88.23% 1 Missing and 1 partial ⚠️
...in/java/io/ballerina/projects/PackageManifest.java 96.49% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             master   #41710    +/-   ##
==========================================
  Coverage     76.69%   76.70%            
- Complexity    52904    52978    +74     
==========================================
  Files          2881     2883     +2     
  Lines        199397   199722   +325     
  Branches      25929    25975    +46     
==========================================
+ Hits         152932   153199   +267     
- Misses        38016    38064    +48     
- Partials       8449     8459    +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShammiL ShammiL force-pushed the new-tool-build-integration branch from 3f7a250 to 4e649ea Compare November 17, 2023 04:09
@ShammiL ShammiL marked this pull request as ready for review November 20, 2023 06:42
@ShammiL ShammiL force-pushed the new-tool-build-integration branch 2 times, most recently from f6a0604 to 888c06e Compare December 1, 2023 15:59
@ShammiL ShammiL force-pushed the new-tool-build-integration branch from d827842 to 59a535b Compare December 20, 2023 11:25
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Coverage on New Code (required ≥ 80%)
3.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@azinneera azinneera merged commit 617e5e4 into master Jan 2, 2024
18 of 21 checks passed
@ThisaruGuruge ThisaruGuruge deleted the new-tool-build-integration branch January 18, 2024 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate code generation bal tools to package build
4 participants