Generate notifications for cyclic dependencies to the LS client #41756
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
When there is a cyclic dependency, the project API is unable to provide compilation. Thus, the LS cannot fulfill any requests such as completions and code actions. This impacts user experience negatively, as it appears unresponsive to the user. As a solution, a notification is displayed to the user when there are cyclic dependencies.
Fixes #41111
Approach
In the same sequence of sending diagnostics to the LS client, alert the user if there is a cyclic dependency diagnostic.
Samples
Remarks
Requires adding a test to check if the notification is produced after a did change once issue #41755 is resolved.
Check List