-
Notifications
You must be signed in to change notification settings - Fork 755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start listening phase even when listeners are only in imported modules #41762
Start listening phase even when listeners are only in imported modules #41762
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #41762 +/- ##
=========================================
Coverage 76.69% 76.70%
- Complexity 52904 52924 +20
=========================================
Files 2881 2881
Lines 199397 199444 +47
Branches 25929 25938 +9
=========================================
+ Hits 152932 152984 +52
+ Misses 38016 38015 -1
+ Partials 8449 8445 -4 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
.../ballerina-lang/src/main/java/org/wso2/ballerinalang/compiler/bir/codegen/JvmPackageGen.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4c7c30b
into
ballerina-platform:master
Purpose
$title
Fixes #41667
Approach
Samples
Remarks
Created ballerina-platform/ballerina-library#5836 to add a test.
Check List