Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start listening phase even when listeners are only in imported modules #41762

Merged

Conversation

Nadeeshan96
Copy link
Contributor

@Nadeeshan96 Nadeeshan96 commented Nov 24, 2023

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

$title
Fixes #41667

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Created ballerina-platform/ballerina-library#5836 to add a test.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • [] Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Nadeeshan96 Nadeeshan96 added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Attention: 58 lines in your changes are missing coverage. Please review.

Comparison is base (612e44f) 76.69% compared to head (a3ee046) 76.70%.
Report is 67 commits behind head on master.

Files Patch % Lines
...ballerinalang/central/client/CentralAPIClient.java 25.53% 29 Missing and 6 partials ⚠️
...n/java/org/ballerinalang/central/client/Utils.java 60.00% 13 Missing and 1 partial ⚠️
...in/java/io/ballerina/cli/task/RunProfilerTask.java 64.28% 4 Missing and 1 partial ⚠️
.../compiler/bir/codegen/interop/JMethodResolver.java 91.17% 1 Missing and 2 partials ⚠️
...lerinalang/compiler/bir/codegen/JvmPackageGen.java 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #41762   +/-   ##
=========================================
  Coverage     76.69%   76.70%           
- Complexity    52904    52924   +20     
=========================================
  Files          2881     2881           
  Lines        199397   199444   +47     
  Branches      25929    25938    +9     
=========================================
+ Hits         152932   152984   +52     
+ Misses        38016    38015    -1     
+ Partials       8449     8445    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HindujaB
HindujaB previously approved these changes Nov 30, 2023
Copy link
Contributor

@HindujaB HindujaB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gabilang
gabilang previously approved these changes Dec 18, 2023
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@warunalakshitha warunalakshitha merged commit 4c7c30b into ballerina-platform:master Jan 2, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Listening phase does not start when listeners are available only in imported modules
4 participants