Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parsing map keys in fromBalString method #41799

Merged

Conversation

Nadeeshan96
Copy link
Contributor

Purpose

Describe the problems, issues, or needs driving this feature/fix and include links to related issues.

$title
Fixes #41700

Approach

Describe how you are implementing the solutions along with the design details.

Samples

Provide high-level details about the samples related to this feature.

Remarks

List any other known issues, related PRs, TODO items, or any other notes related to the PR.

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@Nadeeshan96 Nadeeshan96 added the Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime label Nov 29, 2023
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (04c07e4) 76.70% compared to head (a0c6852) 76.73%.
Report is 32 commits behind head on master.

❗ Current head a0c6852 differs from pull request most recent head 985e312. Consider uploading reports for the commit 985e312 to get more accurate results

Files Patch % Lines
.../io/ballerina/runtime/internal/BalStringUtils.java 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41799      +/-   ##
============================================
+ Coverage     76.70%   76.73%   +0.03%     
+ Complexity    52736    52733       -3     
============================================
  Files          2878     2878              
  Lines        198759   198742      -17     
  Branches      25841    25834       -7     
============================================
+ Hits         152464   152513      +49     
+ Misses        37874    37803      -71     
- Partials       8421     8426       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Nadeeshan96 Nadeeshan96 marked this pull request as ready for review November 30, 2023 07:57
Copy link
Contributor

@warunalakshitha warunalakshitha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HindujaB HindujaB merged commit d1fbfb9 into ballerina-platform:master Dec 7, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/jBallerina All the issues related to BIR, JVM backend code generation and runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: The fromBalString function is not working properly for map expression
3 participants