Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix annotations for the service remote function attachment point #41856

Merged

Conversation

MaryamZi
Copy link
Member

Purpose

$title.

Fixes #41786

Check List

  • Read the Contributing Guide
  • Updated Change Log
  • Checked Tooling Support (#)
  • Added necessary tests
    • Unit Tests
    • Spec Conformance Tests
    • Integration Tests
    • Ballerina By Example Tests
  • Increased Test Coverage
  • Added necessary documentation
    • API documentation
    • Module documentation in Module.md files
    • Ballerina By Examples

@MaryamZi MaryamZi added the Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times. label Dec 11, 2023
@MaryamZi MaryamZi force-pushed the fix-svc-remote-method-annot branch from 7f0b7a7 to f33745f Compare December 11, 2023 06:22
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (300adf5) 76.71% compared to head (cc94e6e) 76.71%.
Report is 3 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #41856      +/-   ##
============================================
- Coverage     76.71%   76.71%   -0.01%     
+ Complexity    53073    53071       -2     
============================================
  Files          2884     2884              
  Lines        200022   200023       +1     
  Branches      26041    26041              
============================================
- Hits         153450   153445       -5     
- Misses        38127    38134       +7     
+ Partials       8445     8444       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MaryamZi MaryamZi marked this pull request as draft December 11, 2023 09:35
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Dec 27, 2023
@MaryamZi MaryamZi removed the Stale label Dec 28, 2023
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jan 12, 2024
@MaryamZi MaryamZi removed the Stale label Jan 13, 2024
@MaryamZi MaryamZi marked this pull request as ready for review January 13, 2024 07:47
Copy link

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

@github-actions github-actions bot added the Stale label Jan 28, 2024
@MaryamZi MaryamZi removed the Stale label Jan 29, 2024
@MaryamZi MaryamZi added this to the 2201.9.0 milestone Feb 22, 2024
@MaryamZi MaryamZi merged commit a9b994b into ballerina-platform:master Feb 22, 2024
17 of 18 checks passed
@MaryamZi MaryamZi deleted the fix-svc-remote-method-annot branch February 22, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team/CompilerFE All issues related to Language implementation and Compiler, this exclude run times.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Annotation with the attach point on a service remote function is not working
4 participants