Make some Java classes proper utilities #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made the design cleaner by marking Java classes as `final` and explicitly declaring their default constructors as `private`. This change makes the code coverage reports more accurate. Closes #4930.
vil02
requested review from
shafreenAnfar,
daneshk and
dilanSachi
as code owners
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1434 +/- ##
============================================
- Coverage 80.54% 80.24% -0.30%
Complexity 56 56
============================================
Files 79 80 +1
Lines 5550 5559 +9
Branches 1290 1294 +4
============================================
- Hits 4470 4461 -9
- Misses 658 677 +19
+ Partials 422 421 -1
☔ View full report in Codecov by Sentry. |
dilanSachi
approved these changes
Oct 17, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
dilanSachi
added
the
Skip GraalVM Check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes ballerina-platform/ballerina-library#4930.
Examples
Checklist