[master] Use toJson method from data.jsondata module in http client and service
#2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Attached the reported issues for jsondata module regarding this migration for tracking the fixes. https://github.com/ballerina-platform/ballerina-library/issues?q=+label%3Amodule%2Fdata.jsondata+author%3Alnash94+ |
lnash94
force-pushed
the
integrate-data.json-2
branch
from
3c2602e to
210b030
Compare
lnash94
requested review from
daneshk,
TharmiganK and
shafreenAnfar
as code owners
TharmiganK
reviewed
Nov 4, 2024
...ain/java/io/ballerina/stdlib/http/api/service/signature/converter/JsonToRecordConverter.java
Outdated
Show resolved
Hide resolved
...ain/java/io/ballerina/stdlib/http/api/service/signature/converter/JsonToRecordConverter.java
Outdated
Show resolved
Hide resolved
TharmiganK
reviewed
Nov 5, 2024
TharmiganK
reviewed
Nov 6, 2024
native/src/main/java/io/ballerina/stdlib/http/api/HttpConstants.java
Outdated
Show resolved
Hide resolved
…s.java Co-authored-by: Krishnananthalingam Tharmigan <63336800+TharmiganK@users.noreply.github.com>
|
lnash94
changed the title
toJson method from data.jsondata module in http clienttoJson method from data.jsondata module in http client and service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix: ballerina-platform/ballerina-library#7012
ballerina-platform/ballerina-library#7011
Client data binding integration: ballerina-platform/ballerina-library#6747
Service data binding integration: ballerina-platform/ballerina-library#7011
Disable the below test because the data.json data module currently does not support the
tabletypesand enable tests once these issues are fixed.
tabletype for ParserAsType method in data.json module ballerina-library#7020toJsonis hanging with theCyclicValueReferenceErrorerror ballerina-library#7326The issue for tracking the disabled tests: ballerina-platform/ballerina-library#7021
Examples
Checklist
Dependent PR : ballerina-platform/module-ballerina-data.jsondata#35 once this is merged , test can be added with new data.jsondata timestamp
Closed PR : #2151