Make some of the Java classes proper utilities #687

vil02 · 2023-10-13T15:00:04Z

Purpose

Fixes: ballerina-platform/ballerina-library#4921.

Examples

Checklist

Made the design cleaner by marking Java classes as `final` and explicitly declaring their default constructors as `private`. This change makes the code coverage reports more accurate. Closes #4921.

codecov · 2023-10-16T05:26:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aea22ae) 80.58% compared to head (763c92f) 80.66%.

Additional details and impacted files

@@             Coverage Diff              @@
##             master     #687      +/-   ##
============================================
+ Coverage     80.58%   80.66%   +0.08%     
  Complexity      109      109              
============================================
  Files            45       45              
  Lines          3965     3961       -4     
  Branches        751      751              
============================================
  Hits           3195     3195              
+ Misses          516      512       -4     
  Partials        254      254

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonarqubecloud · 2023-10-18T05:29:43Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
6.7% Duplication

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

vil02 · 2023-10-18T05:31:11Z

@niveathika I have updated this branch. Could you please approve the workflows again?

niveathika · 2023-10-18T05:40:47Z

@vil02 since these classes are used in other DB connector, these changes must be migrated to ballerina distribution and verified before this can be merged.

vil02 · 2023-10-18T05:45:19Z

@vil02 since these classes are used in other DB connector, these changes must be migrated to ballerina distribution and verified before this can be merged.

@niveathika is there some action I need to take regarding that?

github-actions · 2023-11-02T19:32:37Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

vil02 · 2023-11-02T19:38:04Z

@niveathika @daneshk could you please remove the stale label?

github-actions · 2023-11-19T19:32:38Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

vil02 · 2023-11-19T20:44:13Z

@niveathika @daneshk could you please remove the stale label?

Please don't close.

github-actions · 2023-12-05T19:32:42Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

vil02 · 2023-12-05T19:38:14Z

@niveathika @daneshk could you please remove the stale label?

Please don't close.

Also now.

github-actions · 2023-12-21T19:32:34Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

github-actions · 2023-12-25T19:32:43Z

Closed PR due to inactivity for more than 18 days.

vil02 · 2023-12-26T10:57:34Z

😞

@niveathika is it possible to re-open this PR?

sonarqubecloud · 2024-01-17T08:21:08Z

Quality Gate failed

Failed conditions

5.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

ThisaruGuruge · 2024-01-17T08:21:18Z

😞

@niveathika is it possible to re-open this PR?

We are really very sorry for the late reply. I have reopened this.

github-actions · 2024-02-01T19:32:32Z

This PR has been open for more than 15 days with no activity. This will be closed in 3 days unless the stale label is removed or commented.

vil02 · 2024-02-01T19:57:28Z

@niveathika @daneshk could you please remove the stale label?

Please don't close.

Also now.

Also now.

ThisaruGuruge · 2024-02-06T07:02:10Z

Also now.

Hi @vil02, it seems like the SonarCloud analysis has failed for your PR. Can you please check?

vil02 · 2024-02-06T17:31:36Z

Hi @vil02, it seems like the SonarCloud analysis has failed for your PR. Can you please check?

The complain from SonarCloud seems to a false positive. It complains that I have introduced a duplicated code. Sure... I have introduced private default constructors and other classes, like QueryProcessor, already have it. But it does not work like this.

In my opinion, this complain could be ignored. @ThisaruGuruge: what is you opinion?

daneshk · 2024-02-08T03:37:36Z

Hi @vil02, it seems like the SonarCloud analysis has failed for your PR. Can you please check?

The complain from SonarCloud seems to a false positive. It complains that I have introduced a duplicated code. Sure... I have introduced private default constructors and other classes, like QueryProcessor, already have it. But it does not work like this.

In my opinion, this complain could be ignored. @ThisaruGuruge: what is you opinion?

Thanks for the contribution @vil02. SonarCloud complains about QueryProcessor which is not related to your fix. Let me check the usage of these classes in other db connectors and get back

native/src/main/java/io/ballerina/stdlib/sql/utils/ProcedureCallResultUtils.java

native/src/main/java/io/ballerina/stdlib/sql/utils/RecordIteratorUtils.java

…llResultUtils.java

…torUtils.java

sonarqubecloud · 2024-02-22T16:22:31Z

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

vil02 added 2 commits October 13, 2023 16:48

[Automated] Update native jar versions in toml files

0b6ed10

Make some Java classes proper utilities

70b65bc

Made the design cleaner by marking Java classes as `final` and explicitly declaring their default constructors as `private`. This change makes the code coverage reports more accurate. Closes #4921.

vil02 requested review from daneshk and niveathika as code owners October 13, 2023 15:00

Merge branch 'master' into 4921_make_some_java_classes_proper_utilities

26d70f5

Merge branch 'master' into 4921_make_some_java_classes_proper_utilities

a0c9619

github-actions bot added the Stale label Nov 2, 2023

github-actions bot removed the Stale label Nov 3, 2023

github-actions bot added the Stale label Nov 19, 2023

github-actions bot removed the Stale label Nov 20, 2023

github-actions bot added the Stale label Dec 5, 2023

github-actions bot removed the Stale label Dec 6, 2023

github-actions bot added the Stale label Dec 21, 2023

Merge branch 'master' into 4921_make_some_java_classes_proper_utilities

cfdc678

github-actions bot closed this Dec 25, 2023

ThisaruGuruge reopened this Jan 17, 2024

ThisaruGuruge removed the Stale label Jan 17, 2024

github-actions bot added the Stale label Feb 1, 2024

github-actions bot removed the Stale label Feb 2, 2024

daneshk reviewed Feb 22, 2024

View reviewed changes

native/src/main/java/io/ballerina/stdlib/sql/utils/ProcedureCallResultUtils.java Outdated Show resolved Hide resolved

daneshk reviewed Feb 22, 2024

View reviewed changes

native/src/main/java/io/ballerina/stdlib/sql/utils/RecordIteratorUtils.java Outdated Show resolved Hide resolved

daneshk added 2 commits February 22, 2024 21:51

Update native/src/main/java/io/ballerina/stdlib/sql/utils/ProcedureCa…

adf7243

…llResultUtils.java

Update native/src/main/java/io/ballerina/stdlib/sql/utils/RecordItera…

763c92f

…torUtils.java

daneshk approved these changes Feb 22, 2024

View reviewed changes

daneshk merged commit 7da2c15 into ballerina-platform:master Feb 22, 2024
8 checks passed

vil02 deleted the 4921_make_some_java_classes_proper_utilities branch February 22, 2024 22:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make some of the Java classes proper utilities #687

Make some of the Java classes proper utilities #687

vil02 commented Oct 13, 2023

codecov bot commented Oct 16, 2023 •

edited

Loading

sonarqubecloud bot commented Oct 18, 2023

vil02 commented Oct 18, 2023

niveathika commented Oct 18, 2023

vil02 commented Oct 18, 2023

github-actions bot commented Nov 2, 2023

vil02 commented Nov 2, 2023

github-actions bot commented Nov 19, 2023

vil02 commented Nov 19, 2023

github-actions bot commented Dec 5, 2023

vil02 commented Dec 5, 2023

github-actions bot commented Dec 21, 2023

github-actions bot commented Dec 25, 2023

vil02 commented Dec 26, 2023 •

edited

Loading

sonarqubecloud bot commented Jan 17, 2024

ThisaruGuruge commented Jan 17, 2024

github-actions bot commented Feb 1, 2024

vil02 commented Feb 1, 2024

ThisaruGuruge commented Feb 6, 2024

vil02 commented Feb 6, 2024

daneshk commented Feb 8, 2024

sonarqubecloud bot commented Feb 22, 2024

Make some of the Java classes proper utilities #687

Make some of the Java classes proper utilities #687

Conversation

vil02 commented Oct 13, 2023

Purpose

Examples

Checklist

codecov bot commented Oct 16, 2023 • edited Loading

Codecov Report

sonarqubecloud bot commented Oct 18, 2023

vil02 commented Oct 18, 2023

niveathika commented Oct 18, 2023

vil02 commented Oct 18, 2023

github-actions bot commented Nov 2, 2023

vil02 commented Nov 2, 2023

github-actions bot commented Nov 19, 2023

vil02 commented Nov 19, 2023

github-actions bot commented Dec 5, 2023

vil02 commented Dec 5, 2023

github-actions bot commented Dec 21, 2023

github-actions bot commented Dec 25, 2023

vil02 commented Dec 26, 2023 • edited Loading

sonarqubecloud bot commented Jan 17, 2024

Quality Gate failed

ThisaruGuruge commented Jan 17, 2024

github-actions bot commented Feb 1, 2024

vil02 commented Feb 1, 2024

ThisaruGuruge commented Feb 6, 2024

vil02 commented Feb 6, 2024

daneshk commented Feb 8, 2024

sonarqubecloud bot commented Feb 22, 2024

Quality Gate passed

codecov bot commented Oct 16, 2023 •

edited

Loading

vil02 commented Dec 26, 2023 •

edited

Loading