Make some Java classes proper utilities #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vil02
requested review from
daneshk and
kalaiyarasiganeshalingam
as code owners
Made the design cleaner by marking Java classes as `final` and explicitly declaring their default constructors as `private`. This change makes the code coverage reports more accurate. Closes #5052.
Use proper formatting of the change log.
vil02
force-pushed
the
5052_make_some_java_classes_proper_utilities
branch
from
f4cda42 to
360e313
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #499 +/- ##
============================================
+ Coverage 90.37% 90.90% +0.53%
Complexity 92 92
============================================
Files 12 12
Lines 343 341 -2
Branches 56 56
============================================
Hits 310 310
+ Misses 29 27 -2
Partials 4 4
☔ View full report in Codecov by Sentry. |
kalaiyarasiganeshalingam
approved these changes
Oct 26, 2023
kalaiyarasiganeshalingam
merged commit 8714c27
into
ballerina-platform:master
7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Closes ballerina-platform/ballerina-library#5052.
Examples
Checklist