Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dispatching to custom remote functions #900

Merged
merged 17 commits into from
Feb 8, 2023

Conversation

Bhashinee
Copy link
Member

@Bhashinee Bhashinee commented Feb 2, 2023

Purpose

This is the implementation of the proposal: ballerina-platform/ballerina-library#3670

Examples

Checklist

  • Linked to an issue
  • Updated the specification
  • Updated the changelog
  • Added tests
  • Checked native-image compatibility

@codecov
Copy link

codecov bot commented Feb 2, 2023

Codecov Report

Base: 82.71% // Head: 82.65% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (853baa7) compared to base (931316a).
Patch coverage: 78.04% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #900      +/-   ##
============================================
- Coverage     82.71%   82.65%   -0.07%     
- Complexity      538      546       +8     
============================================
  Files            50       50              
  Lines          2974     3009      +35     
  Branches        478      489      +11     
============================================
+ Hits           2460     2487      +27     
- Misses          376      378       +2     
- Partials        138      144       +6     
Impacted Files Coverage Δ
ballerina/annotation.bal 100.00% <ø> (ø)
...na/stdlib/websocket/WebSocketResourceCallback.java 82.50% <0.00%> (-1.40%) ⬇️
.../stdlib/websocket/WebSocketResourceDispatcher.java 83.68% <84.37%> (-0.07%) ⬇️
...ballerina/stdlib/websocket/WebSocketConstants.java 100.00% <100.00%> (ø)
...tdlib/websocket/server/WebSocketServerService.java 100.00% <100.00%> (ø)
...et/client/listener/WebSocketHandshakeListener.java 92.59% <0.00%> (-3.71%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Bhashinee Bhashinee marked this pull request as ready for review February 6, 2023 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants