Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for service account authorization #158

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Nuvindu
Copy link
Contributor

@Nuvindu Nuvindu commented Nov 11, 2024

@ayeshLK
Copy link
Member

ayeshLK commented Nov 12, 2024

@Nuvindu it is not a good practice to do multiple things in one PR. That can lead to confusions and people reviewing the PR might loose focus. Can you revert the unwanted changes from this PR and only introduce what is described in the PR $subject ?

@Nuvindu Nuvindu changed the base branch from main to backup December 6, 2024 07:09
@Nuvindu Nuvindu changed the base branch from backup to Nuvindu-patch-1 December 6, 2024 07:10
@Nuvindu Nuvindu changed the base branch from Nuvindu-patch-1 to main December 6, 2024 07:10
@Nuvindu Nuvindu force-pushed the workspace-support branch from 64bf417 to 8470bf9 Compare January 2, 2025 10:53
Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a few minor suggestions

ballerina/jwt_oauth2_handler.bal Outdated Show resolved Hide resolved
ballerina/jwt_oauth2_handler.bal Outdated Show resolved Hide resolved
Nuvindu and others added 2 commits January 3, 2025 07:49
Co-authored-by: Nipuna Ransinghe  <nipunaranasinghe93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants