Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default connection properties #769

Merged
merged 6 commits into from
Oct 24, 2023

Conversation

kaneeldias
Copy link
Contributor

@kaneeldias kaneeldias commented Oct 20, 2023

Purpose

$subject

Fixes: ballerina-platform/ballerina-library#5065

This PR sets the default value of the connection string properties encrypt to false and trustServerCertificate to true.

Due to updating the MSSQL driver jar to 10.2, which by default sets the above configs to true and false respectively

@kaneeldias kaneeldias changed the title Test PR with new driver Update default connection properties Oct 23, 2023
@kaneeldias kaneeldias marked this pull request as ready for review October 23, 2023 06:49
Copy link
Member

@daneshk daneshk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaneeldias kaneeldias closed this Oct 24, 2023
@kaneeldias kaneeldias reopened this Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (69ad1a0) 82.25% compared to head (47f1724) 82.05%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #769      +/-   ##
============================================
- Coverage     82.25%   82.05%   -0.21%     
+ Complexity      194      193       -1     
============================================
  Files            17       17              
  Lines           885      886       +1     
  Branches        163      163              
============================================
- Hits            728      727       -1     
- Misses           85       86       +1     
- Partials         72       73       +1     
Files Coverage Δ
.../stdlib/mssql/nativeimpl/ClientProcessorUtils.java 90.00% <100.00%> (+0.52%) ⬆️
...in/java/io/ballerina/stdlib/mssql/utils/Utils.java 80.00% <0.00%> (-4.79%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaneeldias kaneeldias merged commit 86fc681 into ballerina-platform:main Oct 24, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Driver cannot connect to the MSSQL server after migrating to Java 17
2 participants