-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Key Based Authentication for Ballerina Twilio Connector #238
Add API Key Based Authentication for Ballerina Twilio Connector #238
Conversation
Co-authored-by: Ayesh Almeida <77491511+ayeshLK@users.noreply.github.com>
Co-authored-by: Ayesh Almeida <77491511+ayeshLK@users.noreply.github.com>
Co-authored-by: Ayesh Almeida <77491511+ayeshLK@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SachinAkash01 we also need to update the docs and examples with the new changes
Added examples with new changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shall we build the package using gradle so that relevant version information would be updated automatically ?
Along with this change we have to update our documentation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the wrapper-sanitations.md
[1] with the changes we did for the ConnectionConfig
. Shall we do that as well ?
Yes, I'm working on it and will send a separate PR for all the changes related to documentation.
Since this is also related to documentation activity, I thought of adding it to the same PR I have mentioned above.. @ayeshLK |
Co-authored-by: Ayesh Almeida <77491511+ayeshLK@users.noreply.github.com>
Co-authored-by: Ayesh Almeida <77491511+ayeshLK@users.noreply.github.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #238 +/- ##
==========================================
+ Coverage 22.41% 26.53% +4.12%
==========================================
Files 8 5 -3
Lines 2838 2355 -483
Branches 1067 1077 +10
==========================================
- Hits 636 625 -11
+ Misses 2202 1730 -472 ☔ View full report in Codecov by Sentry. |
@SachinAkash01 Please use the "Add suggestion to batch" feature (attached below) instead of applying each suggestion individually. This will keep the commit history cleaner and reduce the need for squashing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose
Fixes: #6245
See Also: #7343
Checklist