Add negative tests for constraint mapper #1559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SachinAkash01
requested review from
hevayo,
NipunaRanasinghe and
lnash94
as code owners
SachinAkash01
changed the title
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## constraint_support #1559 +/- ##
========================================================
+ Coverage 79.98% 80.05% +0.07%
- Complexity 1841 1844 +3
========================================================
Files 125 125
Lines 10301 10309 +8
Branches 1699 1699
========================================================
+ Hits 8239 8253 +14
+ Misses 1475 1470 -5
+ Partials 587 586 -1
☔ View full report in Codecov by Sentry. |
ayeshLK
reviewed
Oct 18, 2023
openapi-cli/src/test/java/io/ballerina/openapi/generators/openapi/NegativeConstraintTests.java
Outdated
Show resolved
Hide resolved
ayeshLK
reviewed
Oct 18, 2023
openapi-cli/src/test/java/io/ballerina/openapi/generators/openapi/TestUtils.java
Outdated
Show resolved
Hide resolved
ayeshLK
reviewed
Oct 18, 2023
...bal-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIComponentMapper.java
Outdated
Show resolved
Hide resolved
ayeshLK
reviewed
Oct 18, 2023
...bal-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIComponentMapper.java
Outdated
Show resolved
Hide resolved
ayeshLK
reviewed
Oct 18, 2023
...bal-service/src/main/java/io/ballerina/openapi/converter/service/OpenAPIComponentMapper.java
Outdated
Show resolved
Hide resolved
ayeshLK
reviewed
Oct 19, 2023
openapi-bal-service/src/main/java/io/ballerina/openapi/converter/Constants.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Ayesh Almeida <77491511+ayeshLK@users.noreply.github.com>
|
Kudos, SonarCloud Quality Gate passed!
|
ayeshLK
approved these changes
Oct 19, 2023
ayeshLK
merged commit adbdc1e
into
ballerina-platform:constraint_support
5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #4945
See Also: #4788