Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master]Fix for changing the OAS byte format from mapping byte[] to string in the Ballerina type #1566

Merged
merged 3 commits into from
Nov 3, 2023

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented Nov 3, 2023

Purpose

Fix ballerina-platform/ballerina-library#5072

As per the OAS specification byte format of the string type

byte – base64-encoded characters, for example, U3dhZ2dlciByb2Nrcw==

should map to the Ballerina string

Automation tests

  • Unit tests - Added

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

#1565

@lnash94 lnash94 changed the title [master]Fix for changing the OAS byte format from mapping byte[] to string in the Ballerina type [master]Fix for changing the OAS byte format from mapping byte[] to string in the Ballerina type Nov 3, 2023
Copy link
Member

@ayeshLK ayeshLK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (321ac86) 80.10% compared to head (92b2a2f) 80.10%.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1566   +/-   ##
=========================================
  Coverage     80.10%   80.10%           
  Complexity     1854     1854           
=========================================
  Files           125      125           
  Lines         10323    10323           
  Branches       1704     1704           
=========================================
  Hits           8269     8269           
  Misses         1464     1464           
  Partials        590      590           
Files Coverage Δ
.../io/ballerina/openapi/core/GeneratorConstants.java 92.03% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@NipunaRanasinghe NipunaRanasinghe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

sonarqubecloud bot commented Nov 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lnash94 lnash94 merged commit 6f46ee5 into ballerina-platform:master Nov 3, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Openapi generation type mismatch from string to byte[]
3 participants