Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master] Provide nil return support for the client generation when the response has no content type instead of giving http:Response #1567

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

lnash94
Copy link
Member

@lnash94 lnash94 commented Nov 7, 2023

Purpose

$ballerina-platform/ballerina-library#5720

Automation tests

  • Unit tests - Added

    Code coverage information

  • Integration tests

    Details about the test cases and coverage

Security checks

Samples

Provide high-level details about the samples related to this feature

Related PRs

#1568

Migrations (if applicable)

Describe migration steps and platforms on which migration has been tested

Test environment

List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested

Learning

Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.

@lnash94 lnash94 force-pushed the 5720 branch 2 times, most recently from fd9fab1 to ac909ab Compare November 8, 2023 05:53
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f46ee5) 80.10% compared to head (ed1ce59) 80.10%.

❗ Current head ed1ce59 differs from pull request most recent head 1f2b689. Consider uploading reports for the commit 1f2b689 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1567   +/-   ##
=========================================
  Coverage     80.10%   80.10%           
- Complexity     1854     1862    +8     
=========================================
  Files           125      125           
  Lines         10323    10325    +2     
  Branches       1704     1708    +4     
=========================================
+ Hits           8269     8271    +2     
  Misses         1464     1464           
  Partials        590      590           
Files Coverage Δ
.../io/ballerina/openapi/core/GeneratorConstants.java 92.03% <ø> (ø)
.../core/generators/client/FunctionBodyGenerator.java 94.53% <100.00%> (-0.07%) ⬇️
...generators/client/FunctionReturnTypeGenerator.java 69.04% <100.00%> (+1.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lnash94 lnash94 marked this pull request as ready for review November 10, 2023 04:42
Copy link
Contributor

@dilanSachi dilanSachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as its the same PR sent fro 1.8.x

@lnash94 lnash94 merged commit 180c373 into ballerina-platform:master Nov 14, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants