Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LTSA demo OCA Bundle and update OCA JSON Files #150

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

swcurran
Copy link
Contributor

This PR completes the LTSA Demo OCA Bundle:

  • Adds the generated OCABundle.json file in the LTSA demo folder
  • Updates the two JSON list files with the new LTSA Bundle

These files will also be autogenerated to the Gh Pages published version of this site when this PR is merged.

@cvarjao -- has the BC Wallet that resolves the OCA Bundles from the GH Pages released yet? That would allow us to eliminate this type of PR and make the generation automatic.

Signed-off-by: Stephen Curran swcurran@gmail.com

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Contributor Author

@arbordeleau -- looks like the files are not valid. I'll take a look and see what is needed. I didn't look carefully enough at the files -- which makes having this auto-verifier a good thing!

I can make the fixes, and I'll let you know what I verify.

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Contributor Author

OK — tricky messages to understand, but the problem was just that the branding.json file was missing the type. I also added in the rest of the fields in the overlay and left them blank. Not crucial, but a little easier to maintain.

Looks clean now.

@esune esune merged commit 2bfcbf4 into bcgov:main Dec 10, 2024
1 check passed
@cvarjao
Copy link
Member

cvarjao commented Dec 10, 2024

@swcurran , bcgov/bc-wallet-mobile#1878 has been done

@swcurran
Copy link
Contributor Author

Working now -- https://bcgov.github.io/aries-oca-bundles/OCABundles/schema/bcgov-digital-trust/LTSA/NewCredCredential/demo/

I needed to kick OCA Explorer to have it reload -- it normally only runs daily, unfortunately...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants