Initial draft of the LSBC OCA Bundles for the credentials rooted in CANdy

[swcurran]

A first cut at the LSBC OCA Bundles. I found a couple of issues that need to be verified:

• The OCABundle.json files (Test and Prod) had an attribute "Credential Type" that is not in the Excel file. If that attribute is needed, it has to be put into the Excel file.
• The identifiers in both the test and prod Readme.md files referenced the same three identifiers, one of which was said to be on CANdy Test, but I couldn't find it, so I removed it.
• We can't have the same identifiers used for different bundles -- only one bundle will ever be seen.
• To be able to test, I set the Test OCA Bundle to use the CANdy Dev identifier, and the Prod OCA Bundle to use the CANdy Test identifier. That will have to be changed before go live.
• I added the links to the Identifiers on CANdy.
• I put the bundles in ".../LSBC/Membership/Prod" and ".../LSBC/Membership/Test". As such, I changed the image paths in the branding.json file (and so in the OCABundle.json) to use those paths. Unfortunately, I can't test the URLs until we merge the PR, so we might have to fix that.

Let me know if you want to change anything, but I think it is safe enough to merge this as is and we can tweak the Bundles from there.

Enjoy!

Signed-off-by: Stephen Curran swcurran@gmail.com

[swcurran]

@knguyenBC and @amanji -- set the two of you as reviewers.

@amanji -- just to make sure I didn't do anything stupid in the structure.
@knguyenBC -- to look at the questions/decisions I listed in the comment above. Please let me know.

Thanks!

[swcurran]

Applied the updates from LSBC and looking good now — all attributes are in and the right identifiers are in place.

The only other point I noticed was that all the attributes were marked as "Flagged", meaning that they are PII (Personally Identifiable Data). I'm not sure if that is accurate or not. You might want to update the field in the XLSX file if some should not be flagged. That said, I'm not sure what the BC Wallet does with that flag, so it may not make any difference. ¯_(ツ)_/¯

I think this is ready for merging, if I can get an approval.

[krobinsonca]

@knguyenBC and @swcurran - I would recommend that the folder name for these actually be "LSBC/Lawyer" not "LSBC/Membership". This is for future plans with other credentials using the same schema but different credential definitions. Also, LSBC wants to move away from the term "Member"

[krobinsonca]

Applied the updates from LSBC and looking good now — all attributes are in and the right identifiers are in place.

The only other point I noticed was that all the attributes were marked as "Flagged", meaning that they are PII (Personally Identifiable Data). I'm not sure if that is accurate or not. You might want to update the field in the XLSX file if some should not be flagged. That said, I'm not sure what the BC Wallet does with that flag, so it may not make any difference. ¯_(ツ)_/¯

I think this is ready for merging, if I can get an approval.

I believe BC Wallet puts an icon next to these and also throws a warning when presenting. I think we should remove the Flagged from all attributes except Names. @knguyenBC - can you do this?

[swcurran]

The "Flagged" attributes have been removed (Catherine/LSBC did that) and the file folder has been renamed.

Ready to go? Suggest we merge and see what we have.

[knguyenBC]

Looks good.

[esune]

LGTM 👍🏻