-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft Mines Permit OCA Bundle #86
Conversation
Signed-off-by: Stephen Curran <swcurran@gmail.com>
We used an example that had all the attribute set as 'Flagged Attributes' it seemed odd but it also didn't seem like PII in the one we were comparing too. That can be changed if it's intention is for PII. Yes, we found the asset from that credential and wanted the exact same asset, we can make our own copy if that is preferred, or maybe a 'shared' location should be made as I predict many BC Gov branded credentials that should be managed by one set of branding.json potentially? |
Not sure the one you were using originally, but if you were using the Person credential, it would make sense that they would be PII, since… “Person” :-) . If another one — I’d question that. But should definitely be off in this one. I’ll make that change. Re: the shared images. I’ll make copies of the images for now, and reference local copies. I agree, there should be a common set that are used, and on the next round, we can do that. I’ll have that done in a moment. |
I notice in the Excel file that the Issuer and Issuer description and Issuer URL are missing. Are there not values we could use for those? |
Signed-off-by: Stephen Curran <swcurran@gmail.com>
Changes made. We can merge with/without the Issuer data, but if you have it — happy to put it in. |
We'll go ahead without the extra issuer data and add it later. |
@Jsyro There are some examples that may have also incorrectly added flagged attributes that are not considered PII. |
Here is a draft of the Mines Permit Branch. In looking at it, I wondered:
Happy to merge once these questions are answered.
FYI: @Jsyro
Thanks!