GitHub Actions, on PR closed: remove oc-login step, install oc #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report (Application)
|
Coverage Report (Frontend)
|
norrisng-bc
force-pushed
the
chore/install-openshift-tools-fix
branch
from
b2183db to
1eb322e
Compare
norrisng-bc
changed the title
norrisng-bc
changed the title
oc login handled by shell script instead as of 30f59cf, but forgot to remove the original GHA step at the time also, install oc
norrisng-bc
force-pushed
the
chore/install-openshift-tools-fix
branch
from
1eb322e to
3fd5c79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #37,
oc-login(GitHub Action) was supposedly replaced withoc login(shell script). For theon-pr-closedaction, the shell script was added, but the corresponding GitHub action wasn't removed at the time. This PR removes it.Installing
ocduring this same action was also left out in the earlier PR, so this has also been corrected.https://apps.nrs.gov.bc.ca/int/jira/browse/SHOWCASE-3816
Types of changes
Bug fix (non-breaking change which fixes an issue)
Checklist
Further comments
N/A