Fixing thunder 1.1.2 release

bczernecki · Sep 7, 2023 · 5d08ba2 · 5d08ba2
1 parent ae123b3
commit 5d08ba2
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 4 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,6 +1,6 @@
 # thundeR 1.1.2
 
-* Allowing to keep NA values in `get_sounding()` which might be not harmful if missing data occur on higher altitudes
+* Allowing to keep NA values in `get_sounding()` which might be not harmful if missing data occur on higher altitudes for dew point temperatures
 
 # thundeR 1.1.1
 

diff --git a/R/get_sounding.R b/R/get_sounding.R
@@ -66,7 +66,11 @@ get_sounding = function(wmo_id, yy, mm, dd, hh, metadata = FALSE) {
     colnames(sounding_data[[1]]) = c("pressure", "altitude", "temp", "dpt",
                                      "rh", "mixr", "wd", "ws", "thta", "thte", "thtv")
     sounding_data[[1]] = sounding_data[[1]][, c("pressure", "altitude", "temp", "dpt","wd", "ws")]
-
+
+    # extra correction for missing entries in the dew oint temperature (only for proper display of the profile):
+    sounding_data[[1]]$dpt[is.na(sounding_data[[1]]$dpt) & !is.na(sounding_data[[1]]$temp)] = -273
+    sounding_data[[1]] = na.omit(sounding_data[[1]])
+
     if (!metadata) {
       sounding_data = sounding_data[[1]]    
     }

diff --git a/tests/testthat/test-get_sounding.R b/tests/testthat/test-get_sounding.R
@@ -6,7 +6,7 @@ test_that("Downloading sounding profile", {
                          dd = 20, 
                          hh = 12)
 
-  expect_equal(nrow(profile), 73)
+  expect_equal(nrow(profile), 72)
   expect_true(is.data.frame(profile))
 })
 
@@ -19,4 +19,4 @@ test_that("Sounding profile error", {
                          hh = 12)
                )
 
-})
+})