Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding/Harmonizing some symbols with small circles #2618

Merged
merged 5 commits into from
Dec 19, 2024
Merged

Conversation

Logo121
Copy link
Contributor

@Logo121 Logo121 commented Dec 17, 2024

Preview

(♭𝄬𝄭♮𝄮𝄯♯𝄰𝄱)

⚬⚭⚮⚯

⯺⯻⯼⯽⊶⊷⧟⟜⊸∘


  • Changes in arrows.ptl (supposedly no glyphs are really affected):
    • Roughly regroup the top-level functions into "Arrow Bars", "Arrow Head/Tails", "Arrow Shapes", "Special Arrow Shapes" (for black/white and rounded arrows), "MkArrow Functions", denoted by comments for now
    • Added the optional argument _halfSw to all Arrow Shape functions (that use halfArrowSw) to override the value (mainly for use outside arrows.ptl)
    • Export TrigArrowShape for
  • Exported AdviceStrokeInSpace for more fine-grained stroke width calculation
  • Modified the metrics of ⊶⊷⧟⟜⊸ so that the calculation is based on the outer radius of the rings
  • ⯺⯻⯼⯽ (Chess Pawn notations)
    • Based on the existing mapping symbols ⊶⊷⧟. These symbols are also modified so that the connecting bar is more visible.
  • ⚭⚮⚯ (Genealogy symbols)
    • Implemented as compositions of a "slightly small white circle"
    • Unicode puts under the same set as these symbols, but it is too big to compose to these symbols. Used a slightly smaller size instead.
  • 𝄬𝄭𝄮𝄯𝄰𝄱 (Accidentals with Up/Down arrow)
    • ♭♮♯ with Up/Down arrow shapes added.
    • On that topic, 𝄲𝄳 is supposed to be a "pitch modifier" different from the quartertone accidentals according to a public comment in Unicode. I didn't move these glyphs as the encoding of the actual quartertone sharp/flats are not stabilized (as of writing), but just as a FYI.

set-width Geom.Width
local offsetX : Geom.Size * Size.SlightlySmall.size / 2
include : union
with-transform [Translate offsetX 0] : refer-glyph : MangleName 'whiteSlightlySmallCircle'
Copy link
Owner

@be5invis be5invis Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make the rings of thinner at Heavy.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since all the partnership symbols refer to one symbol, I'd prefer not to make a separate ring just for . Instead I'm just spacing the gaps more evenly for now.

If this doesn't solve it, it's probably better to use directly for , at the expense of making it differently sized from ⚮⚯.

@jmcwilliams403
Copy link
Contributor

jmcwilliams403 commented Dec 17, 2024

  • On that topic, 𝄲𝄳 is supposed to be a "pitch modifier" different from the quartertone accidentals according to a public comment in Unicode. I didn't move these glyphs as the encoding of the actual quartertone sharp/flats are not stabilized (as of writing), but just as a FYI.

I actually added the characters to the font before that Unicode proposal for the dedicated characters was even filed.

@Logo121
Copy link
Contributor Author

Logo121 commented Dec 18, 2024

  • On that topic, 𝄲𝄳 is supposed to be a "pitch modifier" different from the quartertone accidentals according to a public comment in Unicode. I didn't move these glyphs as the encoding of the actual quartertone sharp/flats are not stabilized (as of writing), but just as a FYI.

I actually added the characters to the font before that Unicode proposal for the dedicated characters was even filed.

Yeah I know, just noting a move is needed eventually because they are now (planned to be) encoded as a separate character.

@Logo121
Copy link
Contributor Author

Logo121 commented Dec 18, 2024

image

@Logo121 Logo121 changed the title Adding/Harmonizing some symbols Adding/Harmonizing some symbol with small circles Dec 18, 2024
@Logo121 Logo121 changed the title Adding/Harmonizing some symbol with small circles Adding/Harmonizing some symbols with small circles Dec 18, 2024
@be5invis be5invis merged commit 4b3e3f8 into be5invis:dev Dec 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants