Validate industries GHA #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsegal205
force-pushed
the
validate-industries
branch
from
39f554d to
f2762b1
Compare
nathanl
approved these changes
Oct 22, 2024
btkostner
reviewed
Oct 22, 2024
|
|
||
| @impl Mix.Task | ||
| @doc false | ||
| def run([file_path]) do |
There was a problem hiding this comment.
It might be worth doing a Path.wildcard so the function can run over all the files. It would be simpler to do it in Elixir than doing it via a bash shell, and it would be easier for devs to run locally.
There was a problem hiding this comment.
I was hesitant to run it over all the files as a good majority of the existing company will likely need to be updated. My thought was adding this so that new or updates to company files could have some data consistency for industries.
This was my attempt at something similar to an ecto changeset validation rule without having or adding ecto back to the project.
I'm open to other ideas or approaches.
doomspork
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds custom validation so that new / updates to company files add a standard for industries.
Supports #671 in the long term