feat(es256k): added optional feature to invert signature #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beatt83
force-pushed
the
feature/bouncy_castle_failsafe
branch
from
ecdefcc to
63c4577
Compare
Since most of other jwt libraries in other languages have the R and S bytes reversed. This has 2 optional features: First you can enable inverted RS signature from ES256KSigner.invertedBytesR_S = true, this will reverse R bytes, reverse S bytes and concatenate both, this will enable the signatures to be verified by other libraries Second you can enable ES256KVerifier.bouncyCastleFailSafe = true this will failsafe to reversing the bytes if the first verification fails. Providing verification for both case scenarios.
beatt83
force-pushed
the
feature/bouncy_castle_failsafe
branch
from
63c4577 to
f65aa6c
Compare
beatt83
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since most of other jwt libraries in other languages have the R and S bytes reversed.
This has 2 optional features:
First you can enable inverted RS signature from ES256KSigner.invertedBytesR_S = true, this will reverse R bytes, reverse S bytes and concatenate both, this will enable the signatures to be verified by other libraries
Second you can enable ES256KVerifier.bouncyCastleFailSafe = true this will failsafe to reversing the bytes if the first verification fails. Providing verification for both case scenarios.