Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for JDK 23 and migrate to Graal compiler 24.1.0 #574

Draft
wants to merge 84 commits into
base: develop
Choose a base branch
from

Conversation

mikepapadim
Copy link
Member

This PR is WIP for TornadoVM running with JDK23 and Graal 24.1.0.

How to test:

make jdk23 BACKEND=opencl
make tests

make jdk23 BACKEND=ptx
make tests

make jdk23 BACKEND=spirv
make tests

@mikepapadim mikepapadim added the graal-update Update the Graal JIT compiler label Oct 1, 2024
@mikepapadim mikepapadim self-assigned this Oct 1, 2024
@mikepapadim mikepapadim requested a review from stratika October 1, 2024 17:27
@jjfumero
Copy link
Member

I get the following error. Can you add the JDK 23 in the installer script?

ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] error: invalid target release: 23
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for tornado 1.0.9-dev:
[INFO] 
[INFO] tornado ............................................ SUCCESS [  0.756 s]
[INFO] tornado-api ........................................ FAILURE [  0.206 s]
[INFO] tornado-runtime .................................... SKIPPED
[INFO] tornado-matrices ................................... SKIPPED
[INFO] tornado-drivers .................................... SKIPPED
[INFO] tornado-drivers-common ............................. SKIPPED
[INFO] tornado-drivers-opencl ............................. SKIPPED
[INFO] tornado-drivers-opencl-jni ......................... SKIPPED
[INFO] tornado-examples ................................... SKIPPED
[INFO] tornado-benchmarks ................................. SKIPPED
[INFO] tornado-unittests .................................. SKIPPED
[INFO] tornado-annotation ................................. SKIPPED
[INFO] tornado-assembly ................................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  1.040 s (Wall Clock)
[INFO] Finished at: 2024-10-17T14:37:19+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile) on project tornado-api: Compilation failure
[ERROR] error: invalid target release: 23
[ERROR] 
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR]   mvn <args> -rf :tornado-api
Error running 'mvn clean': Command '['mvn', '-T1.5C', '-Pjdk23,opencl-backend', 'install']' returned non-zero exit status 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal-update Update the Graal JIT compiler
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants