Fix duplicate database change event send on Library.add #5561
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5560. Also a couple other incidental changes / improvements:
EventType
that holds the actual string literals used for event sending. With type checking, this can prevent subtle bugs resulting from misspelled event names.is_hidden
to takestr
, and convert thosestr
toPath
. Without this fix,test_hidden.py
was failing for me due topath.lstat()
—test_osx_hidden
passes astr
, andstr
doesn't have alstat
method.To Do
Documentation.