Refactor YAML loading into YamlSource class
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple refactoring that just simplifies some calls to `yaml_util.load_yaml` at this point.
This seems to be just fine without it (these are the only names exported here).
Removes the decision from the YamlSource call sites.
beasteers
reviewed
Aug 19, 2020
| if optional and not os.path.isfile(filename): | ||
| value = {} | ||
| else: | ||
| value = yaml_util.load_yaml(filename, loader=loader) or {} |
There was a problem hiding this comment.
This should be in its own load method so it can be called later.
|
Sorry I'm not sure how I missed this. It looks good, but it's very bare bones so I'm just assuming that the plan is to add more in future PRs. So I think it LGTM and we should move on to moving laziness into sources! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step of #96 and @beasteers's approach to lazy source loading. (As a quick recap, that idea is to refactor laziness into the source instead of the configuration object, which is both cleaner and enables mixing-and-matching of lazy and eager sources within the same config.)
This step just consists of an innocuous but nice refactoring to use a
YamlSourceclass to encapsulate the vagaries of loading configuration data from a file. The next step would be to introduce a lazy option here: either alazyparameter to theYamlSourceconstructor or a separateLazyYamlSourceclass (or similar).