Raising importErr when data is not available for testing. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomMoral
reviewed
Nov 19, 2024
datasets/wadi.py
Outdated
Comment on lines
8
to
19
| path = get_data_path(key="WADI") | ||
| if ( | ||
| not (path / "WADI_14days_new.csv").exists() | ||
| ) or ( | ||
| not (path / "WADI_attackdataLABLE.csv").exists() | ||
| ): | ||
| raise ImportError( | ||
| "Test data not found. Please download the data " | ||
| "from the official repository " | ||
| "https://itrust.sutd.edu.sg/itrust-labs_datasets/dataset_info/" | ||
| f" and place it in {path}" | ||
| ) |
There was a problem hiding this comment.
make this a function check_data?
tomMoral
reviewed
Nov 22, 2024
| "from the official repository " | ||
| f"{official_repo[dataset]}" | ||
| f"and place it in {data_path}" | ||
| ) |
There was a problem hiding this comment.
I was thinking more of putting this function in each dataset, but it can be ok like this if you prefer.
benchmark_utils/__init__.py
Outdated
| raise ValueError("dataset must be either 'WADI' or 'SWaT'") | ||
|
|
||
| for file in required_files: | ||
| if not os.path.exists(os.path.join(data_path, file)): |
There was a problem hiding this comment.
don't use os.path but use pathlib.Path.
datasets/swat.py
Outdated
|
|
||
| with safe_import_context() as import_ctx: | ||
| import pandas as pd | ||
|
|
||
| # Checking if the data is available | ||
| path = get_data_path(key="SWaT") |
There was a problem hiding this comment.
If you use a global variable, make it all capital.
Co-authored-by: Thomas Moreau <thomas.moreau.2010@gmail.com>
…chopt-tsad into datasets-importerr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.