Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging for service cleanup hooks in new-style BentoML services #5171

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Add logging for service cleanup hooks in new-style BentoML services #5171

merged 4 commits into from
Jan 7, 2025

Conversation

devin-ai-integration[bot]
Copy link
Contributor

Add logging for service cleanup hooks in new-style BentoML services

This PR adds logging statements to track the execution of cleanup hooks in new-style BentoML services. The changes:

  • Add logging when a cleanup hook starts executing
  • Add completion logging for both sync and async cleanup hooks
  • Only modify the new-style service implementation in app.py
  • Use existing bentoml.server logger

Link to Devin run: https://app.devin.ai/sessions/dd0329173eab41498c7895a12525ed5f

@devin-ai-integration
Add logging for new-style service shutdown hooks in app.py
15ab5c4 
Co-Authored-By: frost@bentoml.com <frost@bentoml.com>
@devin-ai-integration devin-ai-integration bot requested a review from a team as a code owner January 7, 2025 04:06
@devin-ai-integration devin-ai-integration bot requested review from jianshen92 and removed request for a team January 7, 2025 04:06
@devin-ai-integration Devin.ai Integration
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@frostming
Copy link
Contributor

Please log when the service instance destruction completes.

devin-ai-integration bot and others added 2 commits January 7, 2025 04:12
@devin-ai-integration
refactor: improve service cleanup hook logging
6e4c358 
Co-Authored-By: frost@bentoml.com <frost@bentoml.com>
@devin-ai-integration
feat: add service instance cleanup completion logging
bc59126 
Co-Authored-By: frost@bentoml.com <frost@bentoml.com>
@frostming
Copy link
Contributor

Please move the log at L334 to after L339

@devin-ai-integration
refactor: move final cleanup log after proxy closure
b549adc 
Co-Authored-By: frost@bentoml.com <frost@bentoml.com>
@frostming frostming merged commit d1a43c7 into main Jan 7, 2025
50 of 51 checks passed
@frostming frostming deleted the devin/1736222626-add-cleanup-hook-logging branch January 7, 2025 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frostming frostming frostming approved these changes

@jianshen92 jianshen92 Awaiting requested review from jianshen92 jianshen92 is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frostming