test to [[ where available
#261
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes: - init.sh: fix a missing `-d` - github-download: fix a missing `-n` - mount-helper: fix a missing `-n` - setup-git: fix a missing `test`/`[[` - waiter: fix missing `-n` todos: - note this change of convention in the docs - see if there is an alternative for the sudo calls - review the PR to check if there were any errors
- add `is-(directory|file|missing|not-directory|present|readable)(.bash)?` - is-missing: fix incorrect help text on exit status
- mount-helper: fix missing `-n`, however seems better to just always fetch a single line here - debug-network: fix WIP commit using `[[` in a sh script, instead of `[`
- `while true` to `while :`, and `true` to `:` where appropriate - brew: compact a conditional - (choose|config-helper|confirm|echo-lines|is-empty-value|setup-(git|linux|mac|system)): compact an or conditional - is-suffix: update for `__substr` shim in `bash.bash` for bash v3 support - `is-dir`: move to deprecated, as there is now `is-directory`
balupton
commented
Oct 29, 2024
commands/get-terminal-theme
Outdated
| bg="${bg##*;}" # trim everything prior to the last ; | ||
| if test "$bg" = 'default' || test "$bg" -le 6 -o "$bg" -eq 8; then | ||
| if [[ $bg == 'default' ]] || (is-digit -- "$bg" && [[ $bg -le 6 || $bg -eq 8 ]]); then |
There was a problem hiding this comment.
the introduction of is-digit here is a sanity check to prevent weird behaviour
todos:
- choose: needs truncating of choose body, if too long, possible with `fs-rm` and `fs-trim` with large directory content listing: `eza -lA | sed -e '5,$d' -e '4,$s/.*/Truncated./'` is suitable, however our own command would work
- eval-helper: check if pending/success/failure messages are still going to TTY
- is-not-symlink: update copy and pasted tests to match its functionality
- consider renames of `echo-exit-affirmative`, `echo-exit-status`, `is-root`
changes:
- choose:
- optional will now cancel to nothing, only required cancels to defaults
- can now press R to revert to defaults
- dorothy:
- permissions action no longer trims junk files, as they are already git-ignored
- `fs-realpath`, `fs-structure`, `fs-trim`, `is-broken-symlink`, `is-directory`, `is-empty-directory`, `is-empty-file`, `is-file`, `is-missing`, `is-not-directory`, `is-not-symlink`, `is-present`, `is-readable`, `is-symlink`, `is-nonempty-file`:
- support `--(sudo|user|group)` arguments
- consistent internal structure
- add tests where appropriate
- `fs-rm`, `fs-trim`, `fs-structure`:
- rewrote `fs-rm` for new `fs-trim` command, with exact prompts on what to do, no longer overly complex and fragile
- rewrote `fs-structure` to prefer `exa`, comment out verbose `dust`/`du` handling as `exa` is better and more understandable for this use case, made perms and time toggles
- fs-temp:
- clarified touch functionality (will make directories, but not files, by default), make `--no-touch` not make directories
- add `fs-trim`:
- consolidated functionality from: `fs-rm`, `rm-junk`, `rm-modules`
- clear handling of symlinks
- add `is-broken-symlink`, `is-empty-directory`, `is-empty-file`, `is-not-symlink`, `is-file`, `is-not-symlink`, `is-symlink`:
- is-generic:
- change return status behaviour on multiple arguments to be consistent with others
- promoted `is-even` from beta commands
- add `setup-util-qpdf` for `pdf-decrypt`, and updated `pdf-decrypt` for modern covnentions
- sudo-helper:
- add `--[no-]sudo` flag, which if no and no user nor group, then no sudo is needed
fixes:
- choose: pressing escape/q to cancel now works again
- echo-values: fix help text being incorrect
- eval-helper: wrapping will now have wraps go to stdout
- get-terminal-theme: more accurate parsing of `COLORFGBG`
- is-admin: fix multiple users handling
- setup-dns: improve handling of bad interfaces fetch
renames and deprecations:
- `is-nonempty-string` to `is-not-whitespace`
- `is-empty-string` to `is-whitespace`
- `is-empty-ls` to `is-empty-directory`, turns out we had two commands doing the same thing
- `is-dir` to `is-directory`
- `is-either` to `is-needle`, `is-neither` to `! is-needle`
- `echo-if-empty` to `echo-with-whitespace-fallback`, added `echo-with-empty-fallback` for zero-length
- `echo-values` promoted from beta, used within `setup-dns`
- `fs-size` deprecated as it was the same as `fs-structure`; use `fs-structure` or `get-size` instead
- `rm-vmware` to `rm-vmware-fusion`
- `rm-junk` and `rm-modules` to `fs-trim --junk`
- deprecate `is-array-*` and `get-array-*` commands
- deprecate `is-exec`, `is-equal`, `rm-svn`, and `rm-sync` until there is a use case for them
linting:
- down: as `fs-temp` touch usage is now clarified, improve logic around mkdirp call
- fs-filename: use the new options help text format
- get-terminal-color-support: fix return status help text
- remove unnecessary `--status=0` in `eval-tester` calls
- improve wording of return statuses in help text
- improve wording around whether symlinks are considered or not in various commands
- added `Companion to ...` line to improve discovery of (related) commands and their functionality
balupton
force-pushed
the
dev/square-brackets
branch
from
2538a59 to
ccda6c8
Compare
- choose: add `--truncate-body` WIP - config-edit: `--editer=` to `--editor=` - add `echo-truncate-lines` WIP - eval-helper: shapeshifter will be enabled on `sudo-helper` by default - flush-dns, setup-util-docker, setup-util-xcode: fix formatting when sudo needed - fs-rm: rewrote for new `fs-trim` command - get-profile: `possesive-pronoun` to `possesive-pronoun` - git-helper: fix bad formatting on failures - is-present: speedier sudo checks, by first checking without sudo - sudo-helper: support `--optional` for speedier checks without sudo - mount-helper: fixed detection of forced unmount - add `setup-util-tor-browser` - styles: fix terminal title and resize not terminating
balupton
force-pushed
the
dev/square-brackets
branch
3 times, most recently
from
9f7e1e8 to
808f55c
Compare
balupton
force-pushed
the
dev/square-brackets
branch
from
808f55c to
b96a30f
Compare
balupton
force-pushed
the
dev/square-brackets
branch
from
5cc1ae7 to
839a82c
Compare
There was a problem hiding this comment.
Copilot reviewed 559 out of 576 changed files in this pull request and generated no suggestions.
Files not reviewed (17)
- .vscode/workspace.code-workspace: Language not supported
- commands.beta/convert-helper: Language not supported
- commands.beta/echo-affirmative: Language not supported
- commands.beta/echo-escape-special: Language not supported
- commands.beta/echo-exit-affirmative: Language not supported
- commands.beta/echo-exit-status: Language not supported
- commands.beta/echo-html-coder.recode: Language not supported
- commands.beta/echo-html-coder.textutil: Language not supported
- commands.beta/echo-html-coder.xmlstarlet: Language not supported
- commands.beta/echo-if-directory: Language not supported
- commands.beta/echo-if-executable: Language not supported
- commands.beta/echo-if-path: Language not supported
- commands.beta/echo-last-line: Language not supported
- commands.beta/echo-mkdir: Language not supported
- commands.beta/echo-non-affirmative: Language not supported
- commands.beta/echo-nonflags: Language not supported
- commands.beta/echo-nothing-or-fail: Language not supported
- add `echo-if-directory`, `echo-if-executable`, `echo-if-present`, `is-executable`, `is-writable` - `echo-if-file`, `fs-dequarantine` now consistent with other such helpers - fs-trim: fix bad filename code handling, use new `is-needle` flags - is-needle: add `--ignore-case`, `--all`, `--any` flags, and enforce expected arg usage - setup-dns: simplify `fs-rm` call as the extra stuff is no longer necessary - setup-util-bash: simplify `is-needle` call - echo-truncate-lines: move to beta, as no active users - setup-server: use fs helpers wherever appropriate - deprecate `echo-if-path` for `echo-if-present`
balupton
force-pushed
the
dev/square-brackets
branch
3 times, most recently
from
2e4f695 to
72339a7
Compare
balupton
force-pushed
the
dev/square-brackets
branch
2 times, most recently
from
dffa6fc to
dcb21f4
Compare
balupton
force-pushed
the
dev/square-brackets
branch
from
dcb21f4 to
13c335f
Compare
balupton
force-pushed
the
dev/square-brackets
branch
from
13c335f to
3db5aba
Compare
balupton
force-pushed
the
dev/square-brackets
branch
from
c1a9454 to
ad5887c
Compare
also remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This convention change improves performance and resolves edge cases when
test -n "$a" -a "$b" = "$c"wherea=>.fixes:
-d-n-n, one of them seems better to not exist (as we should always just want the first line in that case)test/[[-nother changes:
is-(directory|file|missing|not-directory|present|readable)(.bash)?, such that sudo doesn't have to call problematictestcommandtodos: