-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show these 'fully qualified paths' for bevy_remote's rpc #16944
base: main
Are you sure you want to change the base?
Conversation
…posed to know despite they're not what you'd think...
The generated |
Co-authored-by: Benjamin Brienen <benjamin.brienen@outlook.com>
👍🏽 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm. I can see why this would be useful, but I think it's probably better suited as a doc test in the module docs.
Am I correct in thinking that if they are here [in examples] they're scraped for the docs, but not the other way around? Happy to move them though. @alice-i-cecile whatever you want to do is fine with me. |
Examples getting scraped is a good argument, but Bevy's examples are already rather numerous. I'd like to reserve them for teaching things that must be interactive / rendered, so let's move this information into the docs. |
Examples being visual examples only will help delineate that and it makes sense, since examples are shown on the website as a "look at this". Although, many crates don't have anything to do with visuals and might benefit from bigger examples that aren't well suited to a doc test. |
Yeah, things that demonstrate end-to-end usage patterns can be valuable to teach in examples too! But small snippets / notes like this should just go in the docs. |
I will move them over the weekend. --standby |
Objective
It is not obvious that one would know these:
Especially if you for example, are reading the GH examples because:
If you for example expand these things, due to the number of places bevy re-exports things you'll find it difficult to find the true path of something.
i.e you'd probably be forgiven for writing a query (using the
client.rs
example):which is where
bevy/crates/bevy_pbr/src/mesh_material.rs
Line 41 in 8d9a00f
I've worked with bevy a lot, so it's no issue for me, but for others... ?
However, running this new example:
Solution
Testing
Yes, I ran them. and have been using the output from for the last hour or two.
Showcase
Instead of encouraging this:
We could suggest something like this:
NOTE: ReflectSerialize isn't a thing on MeshMaterial3d, nor indeed on many of the paths that one might explore on the list of returned 'things', but the point should still stand...