Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logic error in loading_screen.rs #16989

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix logic error in loading_screen.rs #16989

wants to merge 2 commits into from
+5 −13

Conversation

BenjaminBrienen
Copy link
Contributor

Objective

Fix #16792

Solution

Fix the logic to retain loaded ones

Testing

Unable to test due to #16988

@BenjaminBrienen BenjaminBrienen self-assigned this Dec 27, 2024
@BenjaminBrienen BenjaminBrienen added C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Dec 27, 2024
@BenjaminBrienen BenjaminBrienen changed the title fix Fix logic error in loading_screen.rs Dec 27, 2024
@MiniaczQ
Copy link
Contributor

Example appears to work correctly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@BenjaminBrienen BenjaminBrienen

Labels
C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in loading_screen.rs example
2 participants
@BenjaminBrienen @MiniaczQ